From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC86C47E49 for ; Wed, 6 Nov 2019 09:11:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39C652053B for ; Wed, 6 Nov 2019 09:11:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lrez6OrO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39C652053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iAyHEbT6gHtTjzwb0/MZ63yVokBr0NX2CnFMGappmu4=; b=lrez6OrOov8APF 6L8v9fjoUPJtAznDtP3lyOg+5AywyKymxQKSBQHcItflIH0erVaBu69AszH7lUt44CYCdJFm364yH 1tPALAN8UluNhnOPd0uwvOGN/pRe4+luyLYMPc5dML7g/voFBQI4TT1UcRj8peXs+ihhlI9bYVoxA gn5MUDT7YSVf0md2Yo1pU92xbY7yAHMDQHFf6ELene1Jof3/ag+A5cYQZXzwbStoaJrbenzsxMZcG lDUTkxZVnjlSt0P1KPn8mk/7pihN68l1RQRZG+nynnWV3JvClnq6f+ksdSg7pkYK2KALq6Xa0FW6t R66xffqkKRay3Us+I+Vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSHLs-000761-Vi; Wed, 06 Nov 2019 09:11:44 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSHLq-00074j-FU; Wed, 06 Nov 2019 09:11:43 +0000 X-UUID: c7e2d9b62a144be4b8364e6f32d31e13-20191106 X-UUID: c7e2d9b62a144be4b8364e6f32d31e13-20191106 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 918528881; Wed, 06 Nov 2019 01:11:24 -0800 Received: from MTKMBS33N1.mediatek.inc (172.27.4.75) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Nov 2019 01:11:33 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Nov 2019 17:11:30 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 6 Nov 2019 17:11:29 +0800 Message-ID: <1573031491.18464.70.camel@mhfsdcap03> Subject: Re: [PATCH 01/28] usb: common: change usb_debug_root as static variable From: Chunfeng Yun To: Guenter Roeck Date: Wed, 6 Nov 2019 17:11:31 +0800 In-Reply-To: <79fd2ebd-b8c6-ee00-c71e-782475a20de6@roeck-us.net> References: <8cb137d5376b4e317dc22dcb9e81a1125b781f8f.1573008519.git.chunfeng.yun@mediatek.com> <79fd2ebd-b8c6-ee00-c71e-782475a20de6@roeck-us.net> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: B2EEFA4A9A6D813BD5B74F951567B8D63F881579AD23F0A50325E8BDEBCFE57E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_011142_527054_4B97F0F8 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Alexandre Belloni , Heikki Krogerus , Wolfram Sang , Yangtao Li , Linus Walleij , linux-kernel@vger.kernel.org, Matthias Brugger , Mans Rullgard , Srinivas Kandagatla , Laurent Pinchart , Fabio Estevam , Florian Fainelli , Robert Jarzmik , Kevin Cernekee , "Gustavo A. R. Silva" , Ludovic Desroches , Alan Stern , NXP Linux Team , bcm-kernel-feedback-list@broadcom.com, David Kershner , Hans Ulli Kroll , Cristian Birsan , linux-media@vger.kernel.org, Fabrizio Castro , Mathias Payer , Mathias Nyman , Suzuki K Poulose , Sascha Hauer , Haojian Zhuang , Stephen Boyd , linux-mediatek@lists.infradead.org, Minas Harutyunyan , Simon Horman , Mauro Carvalho Chehab , Bin Liu , linux-arm-kernel@lists.infradead.org, Biju Das , Felipe Balbi , Laurentiu Tudor , Greg Kroah-Hartman , Yoshihiro Shimoda , linux-usb@vger.kernel.org, Nicolas Ferre , Dmitry Torokhov , Pengutronix Kernel Team , Colin Ian King , Shawn Guo , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2019-11-05 at 20:03 -0800, Guenter Roeck wrote: > On 11/5/19 7:15 PM, Chunfeng Yun wrote: > > Try to avoid using extern global variable, and provide two > > functions for the usage cases > > > > Signed-off-by: Chunfeng Yun > > --- > > drivers/usb/common/common.c | 16 ++++++++++++++-- > > include/linux/usb.h | 5 ++++- > > 2 files changed, 18 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c > > index 1433260d99b4..639ee6d243a2 100644 > > --- a/drivers/usb/common/common.c > > +++ b/drivers/usb/common/common.c > > @@ -293,8 +293,20 @@ struct device *usb_of_get_companion_dev(struct device *dev) > > EXPORT_SYMBOL_GPL(usb_of_get_companion_dev); > > #endif > > > > -struct dentry *usb_debug_root; > > -EXPORT_SYMBOL_GPL(usb_debug_root); > > +static struct dentry *usb_debug_root; > > + > > I don't think it is a good idea to declare this variable static > before all its uses are removed. This patch will leave the system > in a non-compileable state until all patches of the series have > been applied. Yes, you are right, I'll fix it, may be split into two patch > > I am curious. What is the rationale for this change ? > Did exported variables run out of favor ? Personally, I think it's good practice to avoid global varibale, it may not a good reason. another one is that want to create all debug directory/file in usb root for host/device controller drivers. > Sorry if there was a > patch 0 of the series explaining the rationale and I missed it. Sorry, I do not prepare cover latter, will add it if send out next version. > > Guenter _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek