Re: [PATCH 01/28] usb: common: change usb_debug_root as static variable

Chunfeng Yun
2019-11-06T09:26:06Z

On Wed, 2019-11-06 at 09:51 +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 06, 2019 at 08:33:10AM +0100, Wolfram Sang wrote:
> >
> > > Did exported variables run out of favor ? Sorry if there was a
> > > patch 0 of the series explaining the rationale and I missed it.
> >
> > I neither got it if there was one. If there wasn't, I agree a cover
> > letter makes a lot of sense here.
>
> I don't understand why this whole series is needed either.
>
> What is wrong with the original code?
No wrong at all, just think it's good practice to avoid global variable,
more and more controller drivers use it now.
And it's also clear enough for global variable usb_debug_root

> Also, like I said before, you
> broke the build here with the first patch, which is not ok.
>
> greg k-h