From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB938C43603 for ; Wed, 11 Dec 2019 17:48:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C41520663 for ; Wed, 11 Dec 2019 17:48:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ex9mHcT9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="pfltpKZn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C41520663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+l+jVpS5T89TQl8M2QHHXVGadOj8tuDhlwu+qwDja/c=; b=ex9mHcT9Xmrgf7 S4lyKW09jOQN99iojpT8IaYCwrWWyflX3/nrH1+vmAEmQhDkIz97Gj70I116ZGG90IbfZn61EnkyM 1S+WMqukhn6kyoJgS3x5dEqDlJwn5JH7XBTmLBDLUlxspwZ11Y0XMRA/RYGDd3rBwaDeZ9vamEIU0 wfzks99i6kBTf7GCKuM11sXdusMkphC7Un1ObNTM02VpfOr6t2d7uHU8zGKQ7PoONLh3iVuPwBs4D KlvukQGEvQcgMqnpyYD3lnf1tDrBREXAQDYg1+VoxL6KoHpjTJ59GyTuRWbIWizb3CwPUsU+9pjsN /UzYIZQQc16eYIEkgicA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if66A-0003XJ-Ar; Wed, 11 Dec 2019 17:48:30 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if668-0003Wf-Cn for linux-mediatek@lists.infradead.org; Wed, 11 Dec 2019 17:48:29 +0000 X-UUID: beea4c4daa60452c99ce7ff5e0ba7efd-20191211 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=u7qv1t+UEdcZ3p9avQ8ygs4s73dg8OSg8iN56BmCOVg=; b=pfltpKZnVgfgvpFUQxqIxY0veuIleO4Ge2hVHVj5TRDVqWu0xtE0EUSqsQAYLqHYfPyZ2m2f5ZlZwE26Le74VT+Bu4WuBj2YyPmmlSF38TWsWMJXeC43255okcdazeonO0x8R15xhQJx4tla1DDHBdjSGnfKu5xNDkixsXm/r/s=; X-UUID: beea4c4daa60452c99ce7ff5e0ba7efd-20191211 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1710791342; Wed, 11 Dec 2019 09:48:21 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Dec 2019 09:48:35 -0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Dec 2019 01:47:31 +0800 Message-ID: <1576086486.23763.61.camel@mtksdccf07> Subject: Re: [PATCH net-next 4/6] net: dsa: mt7530: Add the support of MT7531 switch From: Landen Chao To: Andrew Lunn Date: Thu, 12 Dec 2019 01:48:06 +0800 In-Reply-To: <20191210164855.GE27714@lunn.ch> References: <6d608dd024edc90b09ba4fe35417b693847f973c.1575914275.git.landen.chao@mediatek.com> <20191210164855.GE27714@lunn.ch> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_094828_452938_459F6A2E X-CRM114-Status: UNSURE ( 6.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "frank-w@public-files.de" , "f.fainelli@gmail.com" , "vivien.didelot@savoirfairelinux.com" , "netdev@vger.kernel.org" , Sean Wang , "linux-kernel@vger.kernel.org" , "opensource@vdorst.com" , "robh+dt@kernel.org" , "linux-mediatek@lists.infradead.org" , "matthias.bgg@gmail.com" , "davem@davemloft.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2019-12-11 at 00:48 +0800, Andrew Lunn wrote: > > +static int mt7531_setup(struct dsa_switch *ds) > > +{ > > + /* Enable PHY power, since phy_device has not yet been created > > + * provided for phy_[read,write]_mmd_indirect is called, we provide > > + * our own mt7531_ind_mmd_phy_[read,write] to complete this > > + * function. > > + */ > > + val = mt7531_ind_mmd_phy_read(priv, 0, PHY_DEV1F, > > + MT7531_PHY_DEV1F_REG_403); > > + val |= MT7531_PHY_EN_BYPASS_MODE; > > + val &= ~MT7531_PHY_POWER_OFF; > > + mt7531_ind_mmd_phy_write(priv, 0, PHY_DEV1F, > > + MT7531_PHY_DEV1F_REG_403, val); > > + > > Is this power to all the PHYs? Or just one? This is an internal circuit that controls the power to all PHYs before Generic MII registers are available. Landen > > Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek