* [PATCH 05/10] drm/mediatek: plane_state->fb iff plane_state->crtc
[not found] <20191213172612.1514842-1-daniel.vetter@ffwll.ch>
@ 2019-12-13 17:26 ` Daniel Vetter
2019-12-17 1:13 ` CK Hu
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Vetter @ 2019-12-13 17:26 UTC (permalink / raw)
To: DRI Development
Cc: Daniel Vetter, Matthias Brugger, linux-mediatek, Philipp Zabel,
CK Hu, Daniel Vetter, linux-arm-kernel
Checking both is one too much, so wrap a WARN_ON around it to stope
the copypasta.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: CK Hu <ck.hu@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index 540ef2faa40a..f0b0325381e0 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -94,7 +94,7 @@ static int mtk_plane_atomic_check(struct drm_plane *plane,
if (!fb)
return 0;
- if (!state->crtc)
+ if (WARN_ON(!state->crtc))
return 0;
ret = mtk_drm_crtc_plane_check(state->crtc, plane,
--
2.24.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 05/10] drm/mediatek: plane_state->fb iff plane_state->crtc
2019-12-13 17:26 ` [PATCH 05/10] drm/mediatek: plane_state->fb iff plane_state->crtc Daniel Vetter
@ 2019-12-17 1:13 ` CK Hu
0 siblings, 0 replies; 2+ messages in thread
From: CK Hu @ 2019-12-17 1:13 UTC (permalink / raw)
To: Daniel Vetter
Cc: DRI Development, linux-mediatek, Philipp Zabel, Matthias Brugger,
Daniel Vetter, linux-arm-kernel
Hi, Daniel:
On Fri, 2019-12-13 at 18:26 +0100, Daniel Vetter wrote:
> Checking both is one too much, so wrap a WARN_ON around it to stope
> the copypasta.
Even though I don't know what is copypasta,
Acked-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: CK Hu <ck.hu@mediatek.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mediatek@lists.infradead.org
> ---
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 540ef2faa40a..f0b0325381e0 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -94,7 +94,7 @@ static int mtk_plane_atomic_check(struct drm_plane *plane,
> if (!fb)
> return 0;
>
> - if (!state->crtc)
> + if (WARN_ON(!state->crtc))
> return 0;
>
> ret = mtk_drm_crtc_plane_check(state->crtc, plane,
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-17 1:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191213172612.1514842-1-daniel.vetter@ffwll.ch>
2019-12-13 17:26 ` [PATCH 05/10] drm/mediatek: plane_state->fb iff plane_state->crtc Daniel Vetter
2019-12-17 1:13 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).