From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BB2C43603 for ; Fri, 20 Dec 2019 01:16:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F7ED24676 for ; Fri, 20 Dec 2019 01:16:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BlxH9cru"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="VBrG2Pvv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F7ED24676 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MaRW2M14dshgKSoNyKnvsnGjP24gfobcHfgSXij3hC0=; b=BlxH9cruqwbdir sSF8iBH0wRPpVUnk+mOMfmSDKdoKtH5xyXJC82bXOLdvxvtYUe2wpSoFx8arge3GS3fzRRfrCUtvu JrZBkPgpsaEMhgA3VPS/FLhCeNrNmtNSHhkuFsCBpCaezcH1vrHCVbron+4zfvl1bVQXDwT55Iw6M cYZiDFjzWxd3KUJbhxCkyP3rbUpuluuULtLJxt4Cijd0iDKW0e07VKH+gvKh94VrfcfZTL10+42wt PVRceel38q3TGEhhU2bUT4CijW059KxAZBXKpaz3H//B7i6koDgKLpS0SEdHbfBgc4Tt6e5KiKhMw njUBRp+reMDmCgiSWpAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii6tb-0005KL-NX; Fri, 20 Dec 2019 01:15:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii6tY-0005JK-KY; Fri, 20 Dec 2019 01:15:58 +0000 X-UUID: 2105e928cc9c42079875f1e22dcff2d3-20191219 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=b5yv46h23CCjvOR/ZEHao3boQBcXYWw6ORSfeX263tk=; b=VBrG2PvvkLgrynvtNg7s9MdCcN11As82Aiv++NANKCXQPtpbKBOlWdVIPrECVNLiAgjyaoC+hRoush30AnzAc/tNFCfTSX1Rpu5yPgp/pqP2VB5A1omZMJbHt1fCIPt81q/LBhNH4G8EeWSxcnsUy7qPs6AbwWp8nZ6JVjch7uo=; X-UUID: 2105e928cc9c42079875f1e22dcff2d3-20191219 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 224172342; Thu, 19 Dec 2019 17:15:48 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 19 Dec 2019 17:16:11 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 20 Dec 2019 09:15:06 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 20 Dec 2019 09:14:47 +0800 Message-ID: <1576804540.13056.22.camel@mtkswgap22> Subject: Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface From: Stanley Chu To: Alim Akhtar Date: Fri, 20 Dec 2019 09:15:40 +0800 In-Reply-To: References: <1576468137-17220-1-git-send-email-stanley.chu@mediatek.com> <1576468137-17220-2-git-send-email-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191219_171556_679612_BCE9B010 X-CRM114-Status: UNSURE ( 7.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "f.fainelli@gmail.com" , "linux-scsi@vger.kernel.org" , "Martin K. Petersen" , Leon Chen =?UTF-8?Q?=28=E9=99=B3=E6=96=87=E9=8F=98=29?= , "Andy Teng \($B{}G!9\(\(B\)" , "James E.J. Bottomley" , Chun-Hung Wu =?UTF-8?Q?=28=E5=B7=AB=E9=A7=BF=E5=AE=8F=29?= , Kuohong Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=8B=E9=B4=BB=29?= , open list , Avri Altman , "linux-mediatek@lists.infradead.org" , Peter Wang =?UTF-8?Q?=28=E7=8E=8B=E4=BF=A1=E5=8F=8B=29?= , Alim Akhtar , Matthias Brugger , Pedro Sousa , "linux-arm-kernel@lists.infradead.org" , "Bean Huo \(beanhuo\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Alim, On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote: > > +/* UFS related SMC call */ > > +#define MTK_SIP_UFS_CONTROL \ > > + MTK_SIP_SMC_CMD(0x276) > > + > How about moving UFS specific stuff to MTK UFS driver and include this > header in driver file? > Rest looks fine. Thanks so much for your review. Our intention is to collect all SMC call command types in MediaTek Chipsets here for easier management. This is the first time we show this header thus only UFS related stuff is present here. > > +#endif > > -- > > 2.18.0 > > Thanks, Stanley _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek