Re: [RESEND 1/4] dt-bindings: regulator: Add document for MT6359 regulator

Lee Jones
2020-01-20T08:43:55Z

On Mon, 20 Jan 2020, Wen Su wrote:

> From: Wen Su <wen.su@mediatek.com>
>
> add dt-binding document for MediaTek MT6359 PMIC
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Wen Su <wen.su@mediatek.com>

These are in the wrong order. Tags should describe history, thus
should be in chronological order. For instance, the ordering you used
describes Rob reviewing the patch *before* you sent it, which is not
possible.

> ---
> .../bindings/regulator/mt6359-regulator.txt | 59 ++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mt6359-regulator.txt

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog