Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359 regulator

Wen Su
2020-02-12T06:09:00Z

Hi,

On Tue, 2020-02-11 at 17:06 +0100, Matthias Brugger wrote:
>
> On 10/02/2020 12:57, Wen Su wrote:
> > Hi,
> >
> > On Thu, 2020-02-06 at 11:49 +0000, Mark Brown wrote:
> >> On Thu, Feb 06, 2020 at 11:06:48AM +0800, Wen Su wrote:
> >>
> >>> +Required properties:
> >>> +- compatible: "mediatek,mt6359-regulator"
> >>
> >> Why does this need a compatible string - it looks like it's just
> >> encoding the way Linux splits devices up into the DT, not
> >> providing some reusable IP block.
> >
> > Thanks for your comments.
> > I will remove it in the next patch.
> >
>
> If this the way to go, then please fix all the other MediaTek binding
> description for regulators (+ the dts) as this is then wrong.
> Thanks!
> Matthias

The mt6359-regulator driver is still a reusable IP block.It could be
adding more other MediaTek pmic mt6359 similar compatible device. But
currently this patch only testing on pmic mt6359.
Is it allowable to keep compatible string in binding description ?

Thanks