Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359 regulator

Matthias Brugger
2020-02-11T16:06:56Z

On 10/02/2020 12:57, Wen Su wrote:
> Hi,
>
> On Thu, 2020-02-06 at 11:49 +0000, Mark Brown wrote:
>> On Thu, Feb 06, 2020 at 11:06:48AM +0800, Wen Su wrote:
>>
>>> +Required properties:
>>> +- compatible: "mediatek,mt6359-regulator"
>>
>> Why does this need a compatible string - it looks like it's just
>> encoding the way Linux splits devices up into the DT, not
>> providing some reusable IP block.
>
> Thanks for your comments.
> I will remove it in the next patch.
>

If this the way to go, then please fix all the other MediaTek binding
description for regulators (+ the dts) as this is then wrong.

Thanks!
Matthias