Re: [PATCH v6 1/4] dt-bindings: display: mediatek: update dpi supported chips

Jitao Shi
2020-02-25T02:01:14Z

On Mon, 2020-02-24 at 15:50 +0800, CK Hu wrote:
> Hi, Jitao:
>
> On Fri, 2020-02-21 at 19:28 +0800, Jitao Shi wrote:
> > Add decriptions about supported chips, including MT2701 & MT8173 &
> > mt8183
> >
> > 1. Add more chips support. ex. MT2701 & MT8173 & MT8183
> > 2. Add property "dpi_pin_mode_swap" and "pinctrl-names" gpio mode dpi mode and
> > gpio oupput-low to avoid leakage current.
> > 3. Add property "dpi_dual_edge" to config the dpi pin output mode dual edge or
> > single edge sample data.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > .../bindings/display/mediatek/mediatek,dpi.txt | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> > index b6a7e7397b8b..cd6a1469c8b7 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> > @@ -7,6 +7,7 @@ output bus.
> >
> > Required properties:
> > - compatible: "mediatek,<chip>-dpi"
> > + the supported chips are mt2701 , mt8173 and mt8183.
> > - reg: Physical base address and length of the controller's registers
> > - interrupts: The interrupt signal from the function block.
> > - clocks: device clocks
> > @@ -16,6 +17,11 @@ Required properties:
> > Documentation/devicetree/bindings/graph.txt. This port should be connected
> > to the input port of an attached HDMI or LVDS encoder chip.
> >
> > +Optional properties:
> > +- dpi_pin_mode_swap: Swap the pin mode between dpi mode and gpio mode.
>
> When you have both pinctrl-name of "gpiomode" and "dpimode", it imply
> that dpi_pin_mode_swap = true, isn't it? If so, I think this property is
> redundant.
>
> Regards,
> CK

Yes,I'll fix it next verision.

Best Regards
Jitao

>
> > +- pinctrl-names: Contain "gpiomode" and "dpimode".
> > +- dpi_dual_edge: Control the RGB 24bit data on 12 pins or 24 pins.
> > +
> > Example:
> >
> > dpi0: dpi@1401d000 {
> > @@ -26,6 +32,11 @@ dpi0: dpi@1401d000 {
> > <&mmsys CLK_MM_DPI_ENGINE>,
> > <&apmixedsys CLK_APMIXED_TVDPLL>;
> > clock-names = "pixel", "engine", "pll";
> > + dpi_dual_edge;
> > + dpi_pin_mode_swap;
> > + pinctrl-names = "gpiomode", "dpimode";
> > + pinctrl-0 = <&dpi_pin_gpio>;
> > + pinctrl-1 = <&dpi_pin_func>;
> >
> > port {
> > dpi0_out: endpoint {