From: Ryder Lee <ryder.lee@mediatek.com>
To: <sean.wang@mediatek.com>
Cc: linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org, lorenzo.bianconi@redhat.com,
Lorenzo Bianconi <lorenzo@kernel.org>,
Soul Huang <Soul.Huang@mediatek.com>,
nbd@nbd.name
Subject: Re: [PATCH 2/3] mt76: mt7615: add missing code for providing aid info to the mcu
Date: Tue, 21 Apr 2020 13:57:54 +0800 [thread overview]
Message-ID: <1587448674.12853.1.camel@mtkswgap22> (raw)
In-Reply-To: <0292e088e934199434f0ea06598274f57a24f3d9.1587445885.git.sean.wang@mediatek.com>
On Tue, 2020-04-21 at 13:20 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Parameters in station record should be kept as up to date as BSS being
> updated.
>
> Fixes: a90b4ba1f134 ("mt76: mt7615: provide aid info to the mcu")
> Suggested-by: YF Luo <Yf.Luo@mediatek.com>
> Suggested-by: Lucy Hsu <Lucy.Hsu@mediatek.com>
> Co-developed-by: Soul Huang <Soul.Huang@mediatek.com>
> Signed-off-by: Soul Huang <Soul.Huang@mediatek.com>
> Co-developed-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/main.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c
> index cdc8babca85a..e5012ad680bb 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c
> @@ -497,9 +497,19 @@ static void mt7615_bss_info_changed(struct ieee80211_hw *hw,
>
> mutex_lock(&dev->mt76.mutex);
>
> - if (changed & BSS_CHANGED_ASSOC)
> + if (changed & BSS_CHANGED_ASSOC) {
> + struct ieee80211_sta *sta;
> +
> mt7615_mcu_add_bss_info(phy, vif, info->assoc);
>
> + rcu_read_lock();
> + sta = ieee80211_find_sta(vif, vif->bss_conf.bssid);
> + rcu_read_unlock();
> +
> + if (sta)
> + mt7615_mcu_sta_add(dev, vif, sta, info->assoc);
> + }
> +
how about this -
https://github.com/ryderlee1110/wireless/blob/mt76/drivers/net/wireless/mediatek/mt76/mt7915/main.c#L434
> if (changed & BSS_CHANGED_ERP_SLOT) {
> int slottime = info->use_short_slot ? 9 : 20;
>
> @@ -557,7 +567,8 @@ int mt7615_mac_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif,
> mt7615_mac_wtbl_update(dev, idx,
> MT_WTBL_UPDATE_ADM_COUNT_CLEAR);
>
> - mt7615_mcu_sta_add(dev, vif, sta, true);
> + if (vif->type != NL80211_IFTYPE_STATION)
> + mt7615_mcu_sta_add(dev, vif, sta, true);
>
> return 0;
> }
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-04-21 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 5:20 [PATCH 1/3] mt76: mt7615: Fix up WMM setting for STA mode sean.wang
2020-04-21 5:20 ` [PATCH 2/3] mt76: mt7615: add missing code for providing aid info to the mcu sean.wang
2020-04-21 5:57 ` Ryder Lee [this message]
2020-04-21 7:23 ` Felix Fietkau
2020-04-21 5:20 ` [PATCH 3/3] mt76: mt7663: fix up BMC entry indicated to unicmd firmware sean.wang
2020-04-21 9:19 ` Felix Fietkau
2020-04-21 12:31 ` [PATCH 1/3] mt76: mt7615: Fix up WMM setting for STA mode Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587448674.12853.1.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox