From: Stanley Chu <stanley.chu@mediatek.com>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"andy.teng@mediatek.com" <andy.teng@mediatek.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
"kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>
Subject: RE: [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag()
Date: Thu, 30 Apr 2020 16:35:25 +0800 [thread overview]
Message-ID: <1588235725.3197.3.camel@mtkswgap22> (raw)
In-Reply-To: <BYAPR04MB46296FE5C0C4AE0CE7B24478FCAA0@BYAPR04MB4629.namprd04.prod.outlook.com>
Hi Avri,
On Thu, 2020-04-30 at 07:56 +0000, Avri Altman wrote:
> >
> > For preparation of LU Dedicated buffer mode support on WriteBooster
> > feature, "index" parameter shall be added and allowed to be specified
> > by callers.
> >
> > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> > Reviewed-by: Bean Huo <beanhuo@micron.com>
> > ---
> > drivers/scsi/ufs/ufs-sysfs.c | 2 +-
> > drivers/scsi/ufs/ufshcd.c | 28 +++++++++++++++-------------
> > drivers/scsi/ufs/ufshcd.h | 2 +-
> > 3 files changed, 17 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c
> > index 93484408bc40..b86b6a40d7e6 100644
> > --- a/drivers/scsi/ufs/ufs-sysfs.c
> > +++ b/drivers/scsi/ufs/ufs-sysfs.c
> > @@ -631,7 +631,7 @@ static ssize_t _name##_show(struct device *dev,
> > \
> > struct ufs_hba *hba = dev_get_drvdata(dev); \
> > pm_runtime_get_sync(hba->dev); \
> > ret = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_READ_FLAG, \
> > - QUERY_FLAG_IDN##_uname, &flag); \
> > + QUERY_FLAG_IDN##_uname, 0, &flag); \
> The sysfs entries for flags needs to get an _index argument now
Sure, I will fix this in next version.
Thanks,
Stanley Chu
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-04-30 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:56 [PATCH v2 0/5] scsi: ufs: support LU Dedicated buffer type for WriteBooster Stanley Chu
2020-04-29 13:56 ` [PATCH v2 1/5] scsi: ufs: allow legacy UFS devices to enable WriteBooster Stanley Chu
2020-04-30 7:44 ` Avri Altman
2020-04-30 8:34 ` Stanley Chu
2020-04-29 13:56 ` [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() Stanley Chu
2020-04-30 7:56 ` Avri Altman
2020-04-30 8:35 ` Stanley Chu [this message]
2020-04-29 13:56 ` [PATCH v2 3/5] scsi: ufs: add LU Dedicated buffer mode support for WriteBooster Stanley Chu
2020-04-30 8:30 ` Avri Altman
2020-04-30 8:37 ` Stanley Chu
2020-04-29 13:56 ` [PATCH v2 4/5] scsi: ufs-mediatek: enable WriteBooster capability Stanley Chu
2020-04-29 13:56 ` [PATCH v2 5/5] scsi: ufs: cleanup WriteBooster feature Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588235725.3197.3.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox