Re: [PATCH] mt76: fix different licenses in same driver

Kalle Valo
2020-05-14T04:04:22Z

Jakub Kicinski <kubakici@wp.pl> writes:

> On Thu, 7 May 2020 15:30:24 +0200 Felix Fietkau wrote:
>> Hi Ryder,
>>
>> I think for this patch we need an explicit ACK from Stanislaw Gruszka
>> and Jakub Kicinski (both Cc'd), because mt76x0 was licensed under GPL.
>
> Thanks, yes, you definitely need an ack, especially from folks who have
> their copyright on the files :/
>
> My personal preference for the license was expressed clearly when the
> code was written and it is GPL-only. Felix, if you prefer the clean up
> I'm happy to ack, but I see no reason to downgrade the license at
> vendor's request.

I think it would be unfortunate to have different licenses in the same
driver. For example think of copying a function from one file to
another, how would we handle that? So my strong recommendation is to use
the same license throughout the driver. And in this case I consider mt76
directory and it's subdirectories as being one driver, please correct me
if that's not the case.

--