Re: [SPAM]Re: [PATCH] mt76: fix different licenses in same driver

Ryder Lee
2020-05-14T20:36:45Z

On Thu, 2020-05-14 at 09:33 -0700, Jakub Kicinski wrote:
> On Thu, 14 May 2020 07:03:45 +0300 Kalle Valo wrote:
> > Jakub Kicinski <kubakici@wp.pl> writes:
> > > On Thu, 7 May 2020 15:30:24 +0200 Felix Fietkau wrote:
> > >> Hi Ryder,
> > >>
> > >> I think for this patch we need an explicit ACK from Stanislaw Gruszka
> > >> and Jakub Kicinski (both Cc'd), because mt76x0 was licensed under GPL.
> > >
> > > Thanks, yes, you definitely need an ack, especially from folks who have
> > > their copyright on the files :/
> > >
> > > My personal preference for the license was expressed clearly when the
> > > code was written and it is GPL-only. Felix, if you prefer the clean up
> > > I'm happy to ack, but I see no reason to downgrade the license at
> > > vendor's request.
> >
> > I think it would be unfortunate to have different licenses in the same
> > driver. For example think of copying a function from one file to
> > another, how would we handle that? So my strong recommendation is to use
> > the same license throughout the driver. And in this case I consider mt76
> > directory and it's subdirectories as being one driver, please correct me
> > if that's not the case.
>
> AFAIU some parts of the code were brought in from mt7601u which has
> a different license. As I said I'm happy with it if Felix feels like
> it's needed. Just not a fan of vendors who barely contribute making
> license changes.

You're right. We didn't get ourselves involved in earlier chipset's
driver development, but we actually pay attention on it for years and
actively join the party. We know open source and community-driven
software development is becoming increasingly important to the wireless
industry. So give us more times we will have more dedicated group of
engineers focused on this area of growing innovation. (we’ve contributes
some patches into MT7615, MT7622, MT7663 and ongoing 11ax devices). We
really appreciate all the effort you guys made for mt76.

Anyway, I'm okay to drop this one or switch to ISC :)

Ryder