From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09079C433DF for ; Sat, 23 May 2020 07:46:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB93A2071C for ; Sat, 23 May 2020 07:46:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TLlh/NF0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RT9OPW5J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB93A2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B4qyeAotHmHjwxYT0E580ww8ca2Qt57DjgfqXi02B5Y=; b=TLlh/NF0G8gTQK lg4LsAbGGSyB7qcR76tImNdA27dJE00uOrGBcq2p2f6Hcy0K+BG1RcyTE90J/fvwOezhAZ5Hgj76b k1fzbCJf2lRuHlyrf1b6FubY+/7BeW6otv9stK4y9REopf5z2Rk8dPcc7OG9lS3MTtueiD1Hw24Rn Ii5p1qgPfx3BCXPf6mgXUnAJ+U/1md1llBoaUSNjAwDhPrYWQQHtteUpCTURF0eh6V+ejioLPv8wI kJIy7uiYluwe4CUmrQiZkttse5clllNdyaBo32QecV/vH7ChfJDVNrfRsKB9ibQKbl7Z9mRnYzx+l 2/2vm05HuxKHMzPnguKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcOrm-00080S-Ss; Sat, 23 May 2020 07:46:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcOri-0007zI-SB for linux-mediatek@lists.infradead.org; Sat, 23 May 2020 07:46:45 +0000 X-UUID: ef25c29a3ae44a35baed4e19b57b3d67-20200522 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=K1YlH6sKupJLxMJK8vacs2+pPTOSyNUkbRTASPYPs78=; b=RT9OPW5J7GOUkmUxh8d8R8DlL7KcSaC82yN9fWOcLe2ZzJmmp6tpKUvjSpYM45kMHs1TWbyJ6zp3x7YSv7LpcijMZifvfT6OPnlCgVWDnW0M0cKwVZ1cm8HrNYXoep2cjI4NSI+fFZj8lQCpyghTsW0AatR/d0T3y+jpJUQu314=; X-UUID: ef25c29a3ae44a35baed4e19b57b3d67-20200522 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 463250327; Fri, 22 May 2020 23:46:30 -0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 23 May 2020 00:46:33 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 23 May 2020 15:46:19 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 23 May 2020 15:46:18 +0800 Message-ID: <1590219979.19657.2.camel@mtkswgap22> Subject: Re: [PATCH] mt76: mt7915: Use proper enum type in __mt7915_mcu_msg_send From: Ryder Lee To: Nathan Chancellor Date: Sat, 23 May 2020 15:46:19 +0800 In-Reply-To: <20200523041923.3332257-1-natechancellor@gmail.com> References: <20200523041923.3332257-1-natechancellor@gmail.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200523_004642_915624_5485D43C X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Felix Fietkau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-05-22 at 21:19 -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:232:9: warning: implicit > conversion from enumeration type 'enum mt76_txq_id' to different > enumeration type 'enum mt7915_txq_id' [-Wenum-conversion] > txq = MT_TXQ_FWDL; > ~ ^~~~~~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:239:9: warning: implicit > conversion from enumeration type 'enum mt76_txq_id' to different > enumeration type 'enum mt7915_txq_id' [-Wenum-conversion] > txq = MT_TXQ_MCU_WA; > ~ ^~~~~~~~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:243:9: warning: implicit > conversion from enumeration type 'enum mt76_txq_id' to different > enumeration type 'enum mt7915_txq_id' [-Wenum-conversion] > txq = MT_TXQ_MCU; > ~ ^~~~~~~~~~ > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:287:36: warning: > implicit conversion from enumeration type 'enum mt7915_txq_id' to > different enumeration type 'enum mt76_txq_id' [-Wenum-conversion] > return mt76_tx_queue_skb_raw(dev, txq, skb, 0); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ > > txq should be a "enum mt76_txq_id" as values of that type are the only > ones assigned to it and that is the type that mt76_tx_queue_skb_raw > expects. > > Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") > Link: https://github.com/ClangBuiltLinux/linux/issues/1035 > Signed-off-by: Nathan Chancellor > --- > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c > index f00ad2b66761..916f664e964e 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c > @@ -220,7 +220,7 @@ static int __mt7915_mcu_msg_send(struct mt7915_dev *dev, struct sk_buff *skb, > { > struct mt7915_mcu_txd *mcu_txd; > u8 seq, pkt_fmt, qidx; > - enum mt7915_txq_id txq; > + enum mt76_txq_id txq; > __le32 *txd; > u32 val; > > > base-commit: c11d28ab4a691736e30b49813fb801847bd44e83 Thanks. I have posted the fix here: https://patchwork.kernel.org/patch/11553415/ This is already in Felix's tree. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek