From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8ACC433E0 for ; Thu, 28 May 2020 12:34:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A68A206C3 for ; Thu, 28 May 2020 12:34:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PfbYD90s"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="oNajzKiE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A68A206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KvrvIvkFDM4kvQg3OyG/jEdCAxyFttYY+Sdldq7Z2Vo=; b=PfbYD90sCdVfWs siMSW66iAL3oTAZfArbuNPn9YVBu5HZTV6I+4iPOQBJjAYoUFxB3Czbr8eDwJGZzOdGO0CrDmAEGw fHmNM4vR5mwb6RcPLFles8VRmswwyMfxXrXSsNQBEfGXxZDKLy+ZfNoZ3jtd9WyjXA4rA95QeA59T HOOerrClzDFrrSj1krs4LzBGWU4hPxrDzIhL0U6Y0LJamnNKF+WCCdBoOZh9Y5CEOg/e1e52qQ8f+ /45z+mIDEKzwowoe0GVGqPE3Xa56X+Tyb+Ev8Qx74ttbFy8UiFBLaYLxHgpp455jfCxXsmIVNSDSI DcIQy2+cfZLKmSRsG/Eg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHkE-0005AK-Sj; Thu, 28 May 2020 12:34:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHkB-00059t-Ns for linux-mediatek@lists.infradead.org; Thu, 28 May 2020 12:34:45 +0000 X-UUID: 648472c1cba849edacd7ae6e183d5221-20200528 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=fKh8D1t1OVVDs+JciXz04pHTnlmXfwWrSIaEhxD3uRw=; b=oNajzKiEN6yCxtUUXWtoje9sKMPO5sD0uk36VuaEqR/pSQUj8ecfLorT5EDowp4y2EDevkhLiHxCV8w25GhdEzSwARh6Hgm3j7LScHy6MiJldvIR8jG8ZJ1Qgvk+vItKZ5dp3hLqgki7Q7A5MCho0t7dRnISbv8WIIeDvGTyols=; X-UUID: 648472c1cba849edacd7ae6e183d5221-20200528 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1801006444; Thu, 28 May 2020 04:34:34 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 May 2020 05:34:36 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 May 2020 20:34:34 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 May 2020 20:34:33 +0800 Message-ID: <1590669276.4266.8.camel@mtkswgap22> Subject: Re: [PATCH v5 4/6] pinctrl: mediatek: add pinctrl support for MT6779 SoC From: Hanks Chen To: Sean Wang Date: Thu, 28 May 2020 20:34:36 +0800 In-Reply-To: References: <1585128694-13881-1-git-send-email-hanks.chen@mediatek.com> <1585128694-13881-5-git-send-email-hanks.chen@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_053443_786284_026A6C12 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Andy Teng , Linus Walleij , lkml , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Mars Cheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-04-02 at 14:46 -0700, Sean Wang wrote: > Hi Hanks, > > On Wed, Mar 25, 2020 at 2:31 AM Hanks Chen wrote: > > > > This adds MT6779 pinctrl driver based on MediaTek pinctrl-paris core. > > > > We can add some useful help text about MT6779 pinctrl, especially > about specific parts like virtual gpio and its attributes > Then Acked-by: Sean Wang > Got it, I'll add it in next version. Thanks for the advices. > > Signed-off-by: Hanks Chen > > Signed-off-by: Mars Cheng > > Signed-off-by: Andy Teng > > --- > > drivers/pinctrl/mediatek/Kconfig | 7 + > > drivers/pinctrl/mediatek/Makefile | 1 + > > drivers/pinctrl/mediatek/pinctrl-mt6779.c | 775 +++++++++ > > drivers/pinctrl/mediatek/pinctrl-mtk-mt6779.h | 2085 +++++++++++++++++++++++++ > > 4 files changed, 2868 insertions(+) > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt6779.c > > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt6779.h > > > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > > index 701f9af..f628d01 100644 > > --- a/drivers/pinctrl/mediatek/Kconfig > > +++ b/drivers/pinctrl/mediatek/Kconfig > > @@ -86,6 +86,13 @@ config PINCTRL_MT6765 > > default ARM64 && ARCH_MEDIATEK > > select PINCTRL_MTK_PARIS > > > > +config PINCTRL_MT6779 > > + bool "Mediatek MT6779 pin control" > > + depends on OF > > + depends on ARM64 || COMPILE_TEST > > + default ARM64 && ARCH_MEDIATEK > > + select PINCTRL_MTK_PARIS > > + > > config PINCTRL_MT6797 > > bool "Mediatek MT6797 pin control" > > depends on OF > > diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile > > index a74325a..59c1c60 100644 > > --- a/drivers/pinctrl/mediatek/Makefile > > +++ b/drivers/pinctrl/mediatek/Makefile > > @@ -11,6 +11,7 @@ obj-$(CONFIG_PINCTRL_MT2712) += pinctrl-mt2712.o > > obj-$(CONFIG_PINCTRL_MT8135) += pinctrl-mt8135.o > > obj-$(CONFIG_PINCTRL_MT8127) += pinctrl-mt8127.o > > obj-$(CONFIG_PINCTRL_MT6765) += pinctrl-mt6765.o > > +obj-$(CONFIG_PINCTRL_MT6779) += pinctrl-mt6779.o > > obj-$(CONFIG_PINCTRL_MT6797) += pinctrl-mt6797.o > > obj-$(CONFIG_PINCTRL_MT7622) += pinctrl-mt7622.o > > obj-$(CONFIG_PINCTRL_MT7623) += pinctrl-mt7623.o > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6779.c b/drivers/pinctrl/mediatek/pinctrl-mt6779.c > > new file mode 100644 > > index 0000000..145bf22 > > --- /dev/null > > +++ b/drivers/pinctrl/mediatek/pinctrl-mt6779.c > > @@ -0,0 +1,775 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2019 MediaTek Inc. > > + * Author: Andy Teng > > + * > > + */ > > + > > +#include "pinctrl-mtk-mt6779.h" > > +#include "pinctrl-paris.h" > > + > > +/* MT6779 have multiple bases to program pin configuration listed as the below: > > + * gpio:0x10005000, iocfg_rm:0x11C20000, iocfg_br:0x11D10000, > > + * iocfg_lm:0x11E20000, iocfg_lb:0x11E70000, iocfg_rt:0x11EA0000, > > + * iocfg_lt:0x11F20000, iocfg_tl:0x11F30000 > > + * _i_based could be used to indicate what base the pin should be mapped into. > > + */ > > + > > +#define PIN_FIELD_BASE(s_pin, e_pin, i_base, s_addr, x_addrs, s_bit, x_bits) \ > > + PIN_FIELD_CALC(s_pin, e_pin, i_base, s_addr, x_addrs, s_bit, x_bits, \ > > + 32, 0) > > + > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek