From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11068C433E0 for ; Mon, 15 Jun 2020 07:34:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFC34206E2 for ; Mon, 15 Jun 2020 07:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YOpOGfoj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="o8c0FPcp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFC34206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LXhhX+EMZ4NxEdeXAb3B5EAqZvf261ROkxIWm55wj9o=; b=YOpOGfojhEzcsg ZIcMrASpSV7p0hBhdDFbVbqMRFzqBlG2alBIHM/LhvAG/6F2zJhVplTJTYIFQRItk0jfjjFLTpRdl vFyCj6m8s2su1/kwiC78q2gGa4q3zs2afJH7YrlSufZNdkXY3IOXC+J1xMnrTdCHUzNgT5znRcA9u aNMrTHaj5VArDTyjePWM+qRDikDJkV2s1t0gj3S9BBDcDZuxxVtRa2FnI1Hca0RELmRwRGCcEpery dQDotfXrv9TB8z4Cf35moBh/ziJbymlo3KxqNIg4tjuN/CUoE8Xr7uWUv/pc6Ew6VBRra6X6nXctV Lxk+eY9/WJ/8ookSIDTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkjcw-00045A-9X; Mon, 15 Jun 2020 07:33:54 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkjci-0003un-AW; Mon, 15 Jun 2020 07:33:42 +0000 X-UUID: 93e2138e26d2435cbcc2d118c25037e7-20200614 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qBTmmysW9mKb6RFIDfIeX1e+1dXzsBfF2+qumyv3dGk=; b=o8c0FPcpuBDXKePFQOGk+QKCHcz4v/jOU34m+VhL7h6DVFLkcvEozZ2PeDQj2ZpDet6LHAUl/Bfuw/tfDoOvprX9Qmj+zh6lEAtMCJuQdePNol5ZvD78uT1SeCRnmLNK7n3zW/hOWNBJ0USkzTDU01rY/SevStDsR8aJyg8Z/vg=; X-UUID: 93e2138e26d2435cbcc2d118c25037e7-20200614 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1397883174; Sun, 14 Jun 2020 23:33:36 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Jun 2020 00:24:05 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 15 Jun 2020 15:24:03 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 15 Jun 2020 15:24:02 +0800 Message-ID: <1592205843.25636.82.camel@mtkswgap22> Subject: RE: [PATCH v2 2/2] scsi: ufs: Add trace event for UIC commands From: Stanley Chu To: Avri Altman Date: Mon, 15 Jun 2020 15:24:03 +0800 In-Reply-To: References: <20200615064753.20935-1-stanley.chu@mediatek.com> <20200615064753.20935-3-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: CCA224B35034D6AA6CDD7520EB7BDB9D9CA9E88F74510A9DD30EC7E85C9088CB2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_003341_655485_BA9BFEAF X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cc.chou@mediatek.com" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "asutoshd@codeaurora.org" , "chaotian.jing@mediatek.com" , "bvanassche@acm.org" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Avri, On Mon, 2020-06-15 at 07:13 +0000, Avri Altman wrote: > > /* Write UIC Cmd */ > > ufshcd_writel(hba, uic_cmd->command & COMMAND_OPCODE_MASK, > > REG_UIC_COMMAND); > > @@ -4825,11 +4847,15 @@ static irqreturn_t ufshcd_uic_cmd_compl(struct > > ufs_hba *hba, u32 intr_status) > > ufshcd_get_uic_cmd_result(hba); > > hba->active_uic_cmd->argument3 = > > ufshcd_get_dme_attr_val(hba); > > + ufshcd_add_uic_command_trace(hba, hba->active_uic_cmd, > > + "complete"); > > complete(&hba->active_uic_cmd->done); > > retval = IRQ_HANDLED; > > } > > > > if ((intr_status & UFSHCD_UIC_PWR_MASK) && hba->uic_async_done) { > > + ufshcd_add_uic_command_trace(hba, hba->active_uic_cmd, > > + "complete"); > > complete(hba->uic_async_done); > > retval = IRQ_HANDLED; > > > Why not call ufshcd_add_uic_command_trace once if retval == IRQ_HANDLED? > Is it that the exact timestamp? Thanks! This makes the code cleaner. Fixed in v3. Stanley Chu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek