RE: [PATCH V9 0/2] media: i2c: Add support for DW9768 VCM

Cao, Bingbu
2020-07-02T05:10:32Z

Hi, Dongchun

I think it need rebase on linuxtv/master.

________________________
BRs,
Bingbu Cao

From: Dongchun Zhu (朱东春) <Dongchun.Zhu@mediatek.com>
Sent: Thursday, July 2, 2020 11:49 AM
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linus.walleij@linaro.org; bgolaszewski@baylibre.com; mchehab@kernel.org; andriy.shevchenko@linux.intel.com; robh+dt@kernel.org; drinkcat@chromium.org; tfiga@chromium.org; Erin Lo (羅雅齡) <erin.lo@mediatek.com>; Louis Kuo (郭德寧) <louis.kuo@mediatek.com>; Sj Huang (黃信璋) <sj.huang@mediatek.com>; matthias.bgg@gmail.com; Cao, Bingbu <bingbu.cao@intel.com>; srv_heupstream <srv_heupstream@mediatek.com>; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-media@vger.kernel.org; devicetree@vger.kernel.org; Shengnan Wang (王圣男) <shengnan.wang@mediatek.com>
Subject: RE: [PATCH V9 0/2] media: i2c: Add support for DW9768 VCM

Hi Sakari,

Sorry to bother you again, but I am so confused about the questions you raised.
I just synced mainline: 5.8-rc3 tarball from https://www.kernel.org/, on which I ran the git am <patch> command.
The patch-applying process shows no error.
-----------------8<-------------------
[mtk15013@mtkslt307 linux]$git apply --check media-i2c-Add-support-for-DW9768-VCM.patch
[mtk15013@mtkslt307 linux]$git am media-i2c-Add-support-for-DW9768-VCM.patch
Applying: media: dt-bindings: media: i2c: Document DW9768 bindings
Applying: media: i2c: dw9768: Add DW9768 VCM driver
-----------------8<-------------------

On the other hand, I also compared dongwoon,dw9768.yaml file with other media device dt-bindings(like imx219.yaml and ov8856.yaml).
It seems there are no apparent differences between them.
Especially, the sentence '# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)' shall be common.
I dunno why here dongwoon,dw9768.yaml reports trailing whitespace warnings while ov8856.yaml is silent.

For the patch failed on MAINTAINERS, I am still curious what's wrong.
In fact, I locally have run parse-maintainers.pl script to check MAINTAINERS file before submitting patch.
The result also reports no errors.
-----------------8<-------------------
[mtk15013@mtkslt307 linux]$perl scripts/parse-maintainers.pl
[mtk15013@mtkslt307 linux]$ls
-----------------8<-------------------

As to Base64 encoding, I checked each patch file again. They are all encoded in UTF-8.
As https://www.base64encode.org/ says, for an example, '77' in ASCII format would be changed to 'T' in Based64-encoded format.
This means there shall be messy code if we adpoting Based64-encoded format.
But I cannot see garbled messages in the current patches.

The DW9768 serials-patch is attached.
@Tomasz @Andy @Rob could anyone help try to see whether the patch can be cherry-picked on Linux master branch or not?
Patchwork link:
https://patchwork.kernel.org/cover/11633291/

Thanks,
Dongchun

-----Original Message-----
From: Sakari Ailus [mailto:sakari.ailus@linux.intel.com]
Sent: Wednesday, July 01, 2020 9:44 PM
To: Dongchun Zhu (朱东春)
Cc: mailto:bgolaszewski@baylibre.com; mailto:mchehab@kernel.org; mailto:andriy.shevchenko@linux.intel.com; mailto:robh+dt@kernel.org; mailto:drinkcat@chromium.org; mailto:tfiga@chromium.org; Erin Lo (羅雅齡); Louis Kuo (郭德寧)
Subject: Re: [PATCH V9 0/2] media: i2c: Add support for DW9768 VCM

Hi Dongchun,

On Wed, Jul 01, 2020 at 12:14:48PM +0000, Dongchun Zhu (朱东春) wrote:
> Hello Sakari,
>
> Thank you for your kindly review : -)
>
> For the trailing whitespaces, did you mean the message in the cover-letter(0/2 patch)?
> I am a little confused about it. In fact, I can't tell the wrong places with my naked eye...
>
> For the conflict in MAINTAINERS vs. current media tree master, did you mean the file name(dongwoon,dw9768.yaml)?
> Do we need to change dt-binding file name from dongwoon,dw9768.yaml to dw9768.yaml?

I mean trailing whitespaces. When applying the patch with git am, this is what you get:

-----------------8<-------------------
$ git am -s /tmp/patchset
Applying: media: dt-bindings: media: i2c: Document DW9768 bindings
.git/rebase-apply/patch:13: trailing whitespace.
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
.git/rebase-apply/patch:14: trailing whitespace.
# Copyright (c) 2020 MediaTek Inc.
.git/rebase-apply/patch:15: trailing whitespace.
%YAML 1.2
.git/rebase-apply/patch:16: trailing whitespace.
---
.git/rebase-apply/patch:17: trailing whitespace.
$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9768.yaml#
error: patch failed: MAINTAINERS:5215
error: MAINTAINERS: patch does not apply Patch failed at 0001 media: dt-bindings: media: i2c: Document DW9768 bindings
hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
-----------------8<-------------------

Also the patches seem to be base64 encoded, something I haven't seen before. That is likely unrelated though.

--
Regards,

Sakari Ailus

************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be
conveyed only to the designated recipient(s). Any use, dissemination,
distribution, printing, retaining or copying of this e-mail (including its
attachments) by unintended recipient(s) is strictly prohibited and may
be unlawful. If you are not an intended recipient of this e-mail, or believe
that you have received this e-mail in error, please notify the sender
immediately (by replying to this e-mail), delete any and all copies of
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!