From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 16/30] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc
Date: Fri, 3 Jul 2020 09:41:05 +0800 [thread overview]
Message-ID: <1593740465.23885.19.camel@mhfsdcap03> (raw)
In-Reply-To: <20200702144625.2533530-17-lee.jones@linaro.org>
On Thu, 2020-07-02 at 15:46 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warnings:
>
> drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes]
> 13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...)
> | ^~~~~~~~~~~~~~
The description doesn't match with the title and code changes
>
> Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/usb/mtu3/mtu3_trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c
> index 4f5e7857ec312..155eae126e5e2 100644
> --- a/drivers/usb/mtu3/mtu3_trace.c
> +++ b/drivers/usb/mtu3/mtu3_trace.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> -/**
> +/*
> * mtu3_trace.c - trace support
> *
> * Copyright (C) 2019 MediaTek Inc.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-07-03 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200702144625.2533530-1-lee.jones@linaro.org>
2020-07-02 14:46 ` [PATCH 16/30] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc Lee Jones
2020-07-03 1:41 ` Chunfeng Yun [this message]
2020-07-02 14:46 ` [PATCH 24/30] usb: mtu3: mtu3_trace: Supply missing mtu3_debug.h include file Lee Jones
2020-07-03 5:41 ` kernel test robot
2020-07-02 14:46 ` [PATCH 25/30] usb: mtu3: mtu3_core: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593740465.23885.19.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox