Re: [PATCH v3 1/2] WIP: ASoC: mediatek: mt6359: add codec driver

Mark Brown
2020-08-14T16:02:05Z

[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]

On Fri, Aug 14, 2020 at 06:45:53PM +0800, Jiaxin Yu wrote:

This looks mostly good, a couple of very small things:

> + ret = regulator_enable(priv->avdd_reg);
> + if (ret) {
> + dev_err(&pdev->dev, "%s(), failed to enable regulator!\n",
> + __func__);
> + return ret;
> + }

You need a remove() function to undo this enable.

> + dev_info(&pdev->dev, "%s(), dev name %s\n",
> + __func__, dev_name(&pdev->dev));

This isn't really adding anything, just remove it - it's not reading
info from the hardware or anything.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]