From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA41C2BBD0 for ; Tue, 8 Sep 2020 05:38:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E952137B for ; Tue, 8 Sep 2020 05:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xT/5/FLN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="SC00cIb1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E952137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i7/C3TuzR0sVmWPkIPQasFTLkq4TG2kjRcl+g/8zO1o=; b=xT/5/FLN/sVawJR0RxitDEiBs 2ArDy/EMitvR2U5iiSYJvDiYnkrim4n3SSZ/S4bI7i7bFrUgZjLc9dmWiDadIBR+2waD0pV4BI0dY V7tOGCMAeP1wq3ZT6l1s6pWMF/pG10YkbvwyWz96FZNn6i6Qyx/jg6tRiC6fhvR5HiiLcqMYi6ZEM PmhMGmyU4wTklJB0rOoxqe8MtB/3tAYUelyLl6uhBiduxO/5IOPUhCsBT/JZhYQE2yv5ZuAqzwSUk fkEkLk1LpSrdVf6/HmRZcy4+hFqXaaqUd3W4bFs7H3CyStgPK6YDTofZQtkmDJq0p0HBfeKE8AUeP L/m4PDoQw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFWKz-0006v7-5o; Tue, 08 Sep 2020 05:38:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFWKw-0006ug-I5 for linux-mediatek@lists.infradead.org; Tue, 08 Sep 2020 05:38:36 +0000 X-UUID: 130e0ef0bac44c958c81f8ed0d5bda45-20200907 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vXxcXjp/u4tUTeNK/WwgFqe99QTu92iZSo4LzEOqHcQ=; b=SC00cIb1DdLbVkCvelNk0WpsvUQlLHam3z1EB4hxDQldxQwgsHh3ZMDXCQqmcK3XHUSTmI5mVkw81HZyzjskxjpp/3hmnpT9tdsmvesQ4DmzAAJRHDhLOaBEBwf6MV1lFebxxGoT9mmtY36PfGiDe16Hz49RERro2FZTQbBlzaQ=; X-UUID: 130e0ef0bac44c958c81f8ed0d5bda45-20200907 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 75528169; Mon, 07 Sep 2020 21:38:27 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 22:38:25 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Sep 2020 13:38:24 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 13:38:25 +0800 Message-ID: <1599543504.16905.65.camel@mtkswgap22> Subject: Re: [PATCH v8 3/3] binder: add transaction latency tracer From: Frankie Chang To: Greg Kroah-Hartman Date: Tue, 8 Sep 2020 13:38:24 +0800 In-Reply-To: <20200907140920.GC3719869@kroah.com> References: <20200907070045.GA605692@kroah.com> <1599480055-25781-1-git-send-email-Frankie.Chang@mediatek.com> <1599480055-25781-4-git-send-email-Frankie.Chang@mediatek.com> <20200907122557.GC2029056@kroah.com> <1599486675.16905.34.camel@mtkswgap22> <20200907140920.GC3719869@kroah.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_013834_908988_76F0F1F5 X-CRM114-Status: GOOD ( 44.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Jian-Min Liu , linux-mediatek@lists.infradead.org, Joel Fernandes , Martijn Coenen , Christian Brauner , Todd Kjos Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2020-09-07 at 16:09 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 09:51:15PM +0800, Frankie Chang wrote: > > On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > > > From: "Frankie.Chang" > > > > > > > > Record start/end timestamp for binder transaction. > > > > When transaction is completed or transaction is free, > > > > it would be checked if transaction latency over threshold > > > > (default 2 sec), if yes, printing related information for tracing. > > > > > > > > /* Implement details */ > > > > - Add latency tracer module to monitor transaction > > > > by attaching to new tracepoints introduced > > > > when transactions are allocated and freed. > > > > The trace_binder_txn_latency_free would not be enabled > > > > by default. Monitoring which transaction is too slow to > > > > cause some of exceptions is important. So we hook the > > > > tracepoint to call the monitor function. > > > > > > > > - Since some of modules would trigger timeout NE > > > > if their binder transaction don't finish in time, > > > > such as audio timeout (5 sec), even BT command > > > > timeout (2 sec), etc. > > > > Therefore, setting the timeout threshold as default > > > > 2 seconds could be helpful to debug. > > > > But this timeout threshold is configurable, to let > > > > all users determine the more suitable threshold. > > > > > > > > - The reason why printing the related information to > > > > kernel information log but not trace buffer is that > > > > some abnormal transactions may be pending for a long > > > > time ago, they could not be recorded due to buffer > > > > limited. > > > > > > > > Signed-off-by: Frankie.Chang > > > > Acked-by: Todd Kjos > > > > --- > > > > drivers/android/Kconfig | 8 +++ > > > > drivers/android/Makefile | 1 + > > > > drivers/android/binder.c | 6 ++ > > > > drivers/android/binder_internal.h | 13 ++++ > > > > drivers/android/binder_latency_tracer.c | 112 +++++++++++++++++++++++++++++++ > > > > drivers/android/binder_trace.h | 26 ++++++- > > > > 6 files changed, 163 insertions(+), 3 deletions(-) > > > > create mode 100644 drivers/android/binder_latency_tracer.c > > > > > > > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > > > > index 53b22e2..8aadaf4 100644 > > > > --- a/drivers/android/Kconfig > > > > +++ b/drivers/android/Kconfig > > > > @@ -54,6 +54,14 @@ config ANDROID_BINDER_IPC_SELFTEST > > > > exhaustively with combinations of various buffer sizes and > > > > alignments. > > > > > > > > +config BINDER_TRANSACTION_LATENCY_TRACKING > > > > + tristate "Android Binder transaction tracking" > > > > + help > > > > + Used for track abnormal binder transaction which is over threshold, > > > > + when the transaction is done or be free, this transaction would be > > > > + checked whether it executed overtime. > > > > + If yes, printing out the detailed info. > > > > + > > > > endif # if ANDROID > > > > > > > > endmenu > > > > diff --git a/drivers/android/Makefile b/drivers/android/Makefile > > > > index c9d3d0c9..c2ffdb6 100644 > > > > --- a/drivers/android/Makefile > > > > +++ b/drivers/android/Makefile > > > > @@ -4,3 +4,4 @@ ccflags-y += -I$(src) # needed for trace events > > > > obj-$(CONFIG_ANDROID_BINDERFS) += binderfs.o > > > > obj-$(CONFIG_ANDROID_BINDER_IPC) += binder.o binder_alloc.o > > > > obj-$(CONFIG_ANDROID_BINDER_IPC_SELFTEST) += binder_alloc_selftest.o > > > > +obj-$(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) += binder_latency_tracer.o > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > > > index 0cab900..65ad38c 100644 > > > > --- a/drivers/android/binder.c > > > > +++ b/drivers/android/binder.c > > > > @@ -2674,6 +2674,7 @@ static void binder_transaction(struct binder_proc *proc, > > > > return_error_line = __LINE__; > > > > goto err_alloc_t_failed; > > > > } > > > > + trace_binder_txn_latency_alloc(t); > > > > INIT_LIST_HEAD(&t->fd_fixups); > > > > binder_stats_created(BINDER_STAT_TRANSACTION); > > > > spin_lock_init(&t->lock); > > > > @@ -5177,6 +5178,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m, > > > > to_proc ? to_proc->pid : 0, > > > > t->to_thread ? t->to_thread->pid : 0, > > > > t->code, t->flags, t->priority, t->need_reply); > > > > + trace_binder_txn_latency_info(m, t); > > > > spin_unlock(&t->lock); > > > > > > > > if (proc != to_proc) { > > > > @@ -5818,4 +5820,8 @@ static int __init binder_init(void) > > > > #define CREATE_TRACE_POINTS > > > > #include "binder_trace.h" > > > > > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_alloc); > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_info); > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_free); > > > > + > > > > MODULE_LICENSE("GPL v2"); > > > > diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h > > > > index 872232f..309d1b10 100644 > > > > --- a/drivers/android/binder_internal.h > > > > +++ b/drivers/android/binder_internal.h > > > > @@ -15,6 +15,11 @@ > > > > #include > > > > #include "binder_alloc.h" > > > > > > > > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > > > > +#include > > > > +#include > > > > +#endif > > > > + > > > > struct binder_context { > > > > struct binder_node *binder_context_mgr_node; > > > > struct mutex context_mgr_node_lock; > > > > @@ -524,6 +529,14 @@ struct binder_transaction { > > > > * during thread teardown > > > > */ > > > > spinlock_t lock; > > > > + /** > > > > + * @timestamp and @tv are used to record the time > > > > + * that the binder transaction startup > > > > + */ > > > > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > > > > + struct timespec64 timestamp; > > > > + struct __kernel_old_timeval tv; > > > > > > As I stated in the 0/3 email, please use the correct in-kernel structure > > > for this. That structure is _ONLY_ for old userspace api compatibility > > > issues. Which is not the case here at all. > > > > > > thanks, > > > greg k-h > > > > Since it's not proper to use timeval & __kernel_old_timeval. > > The remaining structure with tv_usec that I found is > > __kernel_timex_timeval, but I'm not sure if this is proper one or not. > > All I can see is in > > https://lwn.net/ml/linux-kernel/20180705213604.18883-6-deepa.kernel@gmail.com/ > > > > I'm afraid of using wrong structure again. > > Could you give me some advices about this? > > > > Or is there another suitable way to replace timeval > > What exactly are you trying to measure such that you feel you need a > timeval structure? > Actually I'd like to record timestamp with standard time structure, so I used 'struct timeval' in the past patch. However it's deprecated, so I am looking for the alternatives. Additionally, I have already looked some patches that replacing timeval with timespec64. I'll do the same way in next version patch. Many thanks, Frankie _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek