Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Radu Rendec <radu@rendec.net>
To: Hemanth Selam <hemanth.selam@gmail.com>,
	Thomas Gleixner <tglx@kernel.org>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Paul Walmsley	 <pjw@kernel.org>,
	Samuel Holland <samuel.holland@sifive.com>,
	Linus Walleij	 <linusw@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH 02/14] irqchip: fix typos in comments
Date: Sun, 13 Sep 2026 14:31:32 -0400	[thread overview]
Message-ID: <159c52926a01c84a24d039b234bd1d3450fe5a9c.camel@rendec.net> (raw)
In-Reply-To: <20260907065328.32009-1-hemanth.selam@gmail.com>

On Mon, 2026-09-07 at 12:23 +0530, Hemanth Selam wrote:
> Fix typos in comments, reported by scripts/checkpatch.pl using the
> misspelling list in scripts/spelling.txt.  Only touches comments, no code
> changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/irqchip/irq-mtk-cirq.c    | 2 +-
>  drivers/irqchip/irq-sifive-plic.c | 2 +-
>  drivers/irqchip/irq-vic.c         | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

The changes look good, but in my opinion should be split into 3
different patches, one per driver, and grouped into a series. Not that
it matters too much in this particular case (where only comments are
touched), but it's common practice in the Linux kernel development.

There are multiple reasons. The main one is that different drivers can
be reviewed/maintained by different people, and patches to them may be
picked up via different (Git) maintainer trees. Also, some companies
selectively port patches against specific drivers to the kernel trees
they maintain.

> diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
> index 914d1d639fe3..d30c34ce0f56 100644
> --- a/drivers/irqchip/irq-mtk-cirq.c
> +++ b/drivers/irqchip/irq-mtk-cirq.c
> @@ -247,7 +247,7 @@ static int mtk_cirq_suspend(void *data)
>  		writel_relaxed(mask, reg);
>  	}
>  
> -	/* set edge_only mode, record edge-triggerd interrupts */
> +	/* set edge_only mode, record edge-triggered interrupts */
>  	/* enable cirq */
>  	reg = mtk_cirq_reg(cirq_data, CIRQ_CONTROL);
>  	value = readl_relaxed(reg);
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index 5b0dac104814..a7cddadddf40 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -452,7 +452,7 @@ static irq_hw_number_t cp100_get_hwirq(struct plic_handler *handler, void __iome
>  		return 0;
>  
>  	/*
> -	 * Interrupts delievered to hardware still become pending, but only
> +	 * Interrupts delivered to hardware still become pending, but only
>  	 * interrupts that are both pending and enabled can be claimed.
>  	 * Clearing the enable bit for all interrupts but the first pending
>  	 * one avoids a hardware bug that occurs during read from the claim
> diff --git a/drivers/irqchip/irq-vic.c b/drivers/irqchip/irq-vic.c
> index e38104c5064e..607e3284f700 100644
> --- a/drivers/irqchip/irq-vic.c
> +++ b/drivers/irqchip/irq-vic.c
> @@ -478,7 +478,7 @@ static void __init __vic_init(void __iomem *base, int parent_irq, int irq_start,
>  /**
>   * vic_init() - initialise a vectored interrupt controller
>   * @base: iomem base address
> - * @irq_start: starting interrupt number, must be muliple of 32
> + * @irq_start: starting interrupt number, must be multiple of 32
>   * @vic_sources: bitmask of interrupt sources to allow
>   * @resume_sources: bitmask of interrupt sources to allow for resume
>   */


      reply	other threads:[~2026-09-13 18:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  6:53 [PATCH 02/14] irqchip: fix typos in comments Hemanth Selam
2026-09-13 18:31 ` Radu Rendec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159c52926a01c84a24d039b234bd1d3450fe5a9c.camel@rendec.net \
    --to=radu@rendec.net \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=hemanth.selam@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pjw@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox