From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5908C433EF for ; Mon, 25 Oct 2021 03:58:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 756786103D for ; Mon, 25 Oct 2021 03:58:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 756786103D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M0zS8b15qQ/pSQjGFyT5nfYTB3oM+o5IVaTlhoM90tM=; b=eW77t3lZkSbkWS UDAI1LdrtNb/J8IgxIYwhsBALii7R1LkY+yHfo5LOyI8Tcjg55uHA7HlAmE5WtN/7is6MxJytXpMg Yo4egfwcWcLrC5cv1FBt0lZIrgIvuS8c7wJpVLyplHTA3s18t9mAVAjcUVMqdOVJ47ltII8gqJWWD O24OVmySoqTpC90DNIE3uroxRd/0bQC+b8C9B9od7SulxXr1564/PJytWLumXsK4T6uKiVWWqliQ/ P1tOU4fkU9NQAWd0zpgTuiGmFX/46vSvUYlBklif4Fk1imEPWZWLxX2OMqCkW6/c1iII40adEUK/B RbElWIzuwP3ZmGpN/6Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mer7a-00FDgB-30; Mon, 25 Oct 2021 03:58:02 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mer7N-00FDdH-1Z; Mon, 25 Oct 2021 03:57:50 +0000 X-UUID: 4b22ebbaa2854463a5c471b3494580d6-20211024 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=cV6dg7PsYHB6+UKop/Sg0rROLJ+oreSSfppKhlC8xGE=; b=nBkGbQeC+Sa3c4WFbs6Ky01mc0hcpUC1VdMIVgp0Ci+nREwXGSXct8xkBhX2s3ToXb8z7bOAWuCxF6sm2/w1ZbvpyLWXSZSkGdcufbA7YrxHi4qeoC1Ri9RoqAAxoOpOmRoxjwmLJ+sjifSy3adpDDGLiZMJznJ7HwbTckMDANs=; X-UUID: 4b22ebbaa2854463a5c471b3494580d6-20211024 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 691523356; Sun, 24 Oct 2021 20:57:44 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 24 Oct 2021 20:57:42 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 25 Oct 2021 11:57:40 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 25 Oct 2021 11:57:39 +0800 Message-ID: <15d4ccb984f9e3919d6d7535d05aec0332dbe301.camel@mediatek.com> Subject: Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices From: Yong Wu To: Dafna Hirschfeld , Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , David Airlie , "Mauro Carvalho Chehab" CC: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , , , , , , , , Matthias Kaehlcke , , , , , , "Daniel Vetter" , Chun-Kuang Hu , "Philipp Zabel" , Tiffany Lin , Hsin-Yi Wang , Eizan Miyamoto , , Frank Wunderlich Date: Mon, 25 Oct 2021 11:57:39 +0800 In-Reply-To: References: <20210929013719.25120-1-yong.wu@mediatek.com> <20210929013719.25120-5-yong.wu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211024_205749_101268_937A797C X-CRM114-Status: GOOD ( 44.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2021-10-18 at 09:13 +0200, Dafna Hirschfeld wrote: > > On 16.10.21 04:23, Yong Wu wrote: > > On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: > > > > > > On 29.09.21 03:37, Yong Wu wrote: > > > > MediaTek IOMMU-SMI diagram is like below. all the consumer > > > > connect > > > > with > > > > smi-larb, then connect with smi-common. > > > > > > > > M4U > > > > | > > > > smi-common > > > > | > > > > ------------- > > > > | | ... > > > > | | > > > > larb1 larb2 > > > > | | > > > > vdec venc > > > > > > > > When the consumer works, it should enable the smi-larb's power > > > > which > > > > also need enable the smi-common's power firstly. > > > > > > > > Thus, First of all, use the device link connect the consumer > > > > and > > > > the > > > > smi-larbs. then add device link between the smi-larb and smi- > > > > common. > > > > > > > > This patch adds device_link between the consumer and the larbs. > > > > > > > > When device_link_add, I add the flag DL_FLAG_STATELESS to avoid > > > > calling > > > > pm_runtime_xx to keep the original status of clocks. It can > > > > avoid > > > > two > > > > issues: > > > > 1) Display HW show fastlogo abnormally reported in [1]. At the > > > > beggining, > > > > all the clocks are enabled before entering kernel, but the > > > > clocks > > > > for > > > > display HW(always in larb0) will be gated after clk_enable and > > > > clk_disable > > > > called from device_link_add(->pm_runtime_resume) and rpm_idle. > > > > The > > > > clock > > > > operation happened before display driver probe. At that time, > > > > the > > > > display > > > > HW will be abnormal. > > > > > > > > 2) A deadlock issue reported in [2]. Use DL_FLAG_STATELESS to > > > > skip > > > > pm_runtime_xx to avoid the deadlock. > > > > > > > > Corresponding, DL_FLAG_AUTOREMOVE_CONSUMER can't be added, then > > > > device_link_removed should be added explicitly. > > > > > > > > [1] > > > > https://lore.kernel.org/linux-mediatek/1564213888.22908.4.camel@mhfsdcap03/ > > > > [2] https://lore.kernel.org/patchwork/patch/1086569/ > > > > > > > > Suggested-by: Tomasz Figa > > > > Signed-off-by: Yong Wu > > > > Tested-by: Frank Wunderlich # BPI- > > > > R2/MT7623 > > > > --- > > > > drivers/iommu/mtk_iommu.c | 22 ++++++++++++++++++++++ > > > > drivers/iommu/mtk_iommu_v1.c | 20 +++++++++++++++++++- > > > > 2 files changed, 41 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/iommu/mtk_iommu.c > > > > b/drivers/iommu/mtk_iommu.c > > > > index d5848f78a677..a2fa55899434 100644 > > > > --- a/drivers/iommu/mtk_iommu.c > > > > +++ b/drivers/iommu/mtk_iommu.c > > > > @@ -560,22 +560,44 @@ static struct iommu_device > > > > *mtk_iommu_probe_device(struct device *dev) > > > > { > > > > struct iommu_fwspec *fwspec = > > > > dev_iommu_fwspec_get(dev); > > > > struct mtk_iommu_data *data; > > > > + struct device_link *link; > > > > + struct device *larbdev; > > > > + unsigned int larbid; > > > > > > > > if (!fwspec || fwspec->ops != &mtk_iommu_ops) > > > > return ERR_PTR(-ENODEV); /* Not a iommu client > > > > device > > > > */ > > > > > > > > data = dev_iommu_priv_get(dev); > > > > > > > > + /* > > > > + * Link the consumer device with the smi-larb > > > > device(supplier) > > > > + * The device in each a larb is a independent HW. thus > > > > only > > > > link > > > > + * one larb here. > > > > + */ > > > > + larbid = MTK_M4U_TO_LARB(fwspec->ids[0]); > > > > > > so larbid is always the same for all the ids of a device? > > > > Yes. For me, each a dtsi node should represent a HW unit which can > > only > > connect one larb. > > > > > If so maybe it worth testing it and return error if this is not > > > the > > > case. > > > > Thanks for the suggestion. This is very helpful. I did see someone > > put > > the different larbs in one node. I will check this, and add return > > I am working on bugs found on media drivers, could you please point > me to > that wrong node? > Will you send a fix to that node in the dtsi? sorry. I mean it happened in the internal branch and it has already been fixed internally, all the upstream nodes are ok for this. Thanks > > > Thanks, > Dafna > > > EINVAL for this case. > > > > > > > > > > > Thanks, > > > Dafna > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek