Re: [PATCH v15 2/2] media: i2c: Add OV02A10 image sensor driver

Andy Shevchenko
2020-11-19T13:56:42Z

On Thu, Nov 19, 2020 at 09:06:41PM +0800, Dongchun Zhu wrote:
> On Fri, 2020-10-23 at 17:31 +0300, Andy Shevchenko wrote:
> > On Tue, Oct 13, 2020 at 09:05:03PM +0800, Dongchun Zhu wrote:
> > > Add a V4L2 sub-device driver for OmniVision OV02A10 image sensor.

...

> > > +#define OV02A10_ID_MASK 0xffff
> >
> > GENMASK()
> >
> > (And include bits.h for that)
> >
>
> It seems could build pass without including bits.h, as DW9768 once used.

The rule of thumb is to include all headers you have direct users for.
Exceptions when you have indirect inclusion that guarantees to provide
others (like bitmap.h implies bits.h, etc).

--
With Best Regards,
Andy Shevchenko