RE: [PATCH v4 0/8] Refine error history and introduce event_notify vop

From: Stanley Chu <stanley.chu@mediatek.com>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "Alice Chao (?w??均)" <Alice.Chao@mediatek.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"Huadian Liu (刘华典)" <huadian.liu@mediatek.com>,
	"Andy Teng (??如宏)" <Andy.Teng@mediatek.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"Chun-Hung Wu (巫?E宏)" <Chun-hung.Wu@mediatek.com>,
	"Kuohong Wang (王????)" <kuohong.wang@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"CC Chou (周志杰)" <cc.chou@mediatek.com>,
	"Jiajie Hao (郝加节)" <jiajie.hao@mediatek.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>
Subject: RE: [PATCH v4 0/8] Refine error history and introduce event_notify vop
Date: Sat, 5 Dec 2020 20:07:33 +0800	[thread overview]
Message-ID: <1607170053.3580.2.camel@mtkswgap22> (raw)
In-Reply-To: <DM6PR04MB657567F698B1EEA7D848FE45FCF00@DM6PR04MB6575.namprd04.prod.outlook.com>

Hi Avri,

On Sat, 2020-12-05 at 16:05 +0800, Avri Altman wrote:
> > 
> > Hi Stanley,
> > Will you split this series to 3 separate series:
> > Phy initialization cleanup, Error history, and event notification?
> > As those 3 aren't really connected?
> > 
> > Please maintain Can's reviewed-by tag for the error history patches,
> > And add mine for the phy initialization, so Martin can pick those.
> And for the new event notification vop of course.  Sorry.

Thanks for the review!

Sure I would separate it to 2 series
1. Cleanup phy_initialization
2. Error history and event notification since these patches are strongly
related

Please review my new posted series and feel free to provide any further
suggestion.

Thanks,
Stanley Chu 

> 
> Thanks,
> Avri
> 
> > 
> > Thanks,
> > Avri
> > 
> > >
> > > Hi,
> > > This series refines error history functions, do vop cleanups and introduce a
> > > new event_notify vop to allow vendor to get notification of important
> > > events.
> > >
> > > Changes since v3:
> > >   - Fix build warning in patch [8/8]
> > >
> > > Changes since v2:
> > >   - Add patches for vop cleanups
> > >   - Introduce phy_initialization helper and replace direct invoking in ufs-cdns
> > > and ufs-dwc by the helper
> > >   - Introduce event_notify vop implemntation in ufs-mediatek
> > >
> > > Changes since v1:
> > >   - Change notify_event() to event_notify() to follow vop naming covention
> > >
> > > Stanley Chu (8):
> > >   scsi: ufs: Remove unused setup_regulators variant function
> > >   scsi: ufs: Introduce phy_initialization helper
> > >   scsi: ufs-cdns: Use phy_initialization helper
> > >   scsi: ufs-dwc: Use phy_initialization helper
> > >   scsi: ufs: Add error history for abort event in UFS Device W-LUN
> > >   scsi: ufs: Refine error history functions
> > >   scsi: ufs: Introduce event_notify variant function
> > >   scsi: ufs-mediatek: Introduce event_notify implementation
> > >
> > >  drivers/scsi/ufs/cdns-pltfrm.c        |   3 +-
> > >  drivers/scsi/ufs/ufs-mediatek-trace.h |  37 ++++++++
> > >  drivers/scsi/ufs/ufs-mediatek.c       |  12 +++
> > >  drivers/scsi/ufs/ufshcd-dwc.c         |  11 +--
> > >  drivers/scsi/ufs/ufshcd.c             | 132 ++++++++++++++------------
> > >  drivers/scsi/ufs/ufshcd.h             | 100 +++++++++----------
> > >  6 files changed, 175 insertions(+), 120 deletions(-)
> > >  create mode 100644 drivers/scsi/ufs/ufs-mediatek-trace.h
> > >
> > > --
> > > 2.18.0
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek