Re: [PATCH 1/3] dt-bindings: usb: mtk-xhci: add a new property for broken streams

Rob Herring
2020-12-21T19:29:31Z

On Wed, Dec 16, 2020 at 07:51:23PM +0800, Chunfeng Yun wrote:
> The 0.96 xHCI controller on some platforms does not support
> bulk stream even HCCPARAMS says supporting, due to MaxPSASize
> is set a non-zero default value by mistake, so add a new
> property "mediatek,broken_streams_quirk" to fix it.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> this patch depends on:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=402773
> [v4,09/11] dt-bindings: usb: convert mediatek, mtk-xhci.txt to YAML schema
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index e5e03f902802..330f7294bf34 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -120,6 +120,11 @@ properties:
> description: The mask to disable u3ports, bit0 for u3port0,
> bit1 for u3port1, ... etc
>
> + mediatek,broken_streams_quirk:

You should imply this from the compatible property.

(Also, don't use '_' in property names).

> + description: set if the controller doesn't support bulk stream but
> + HCCPARAMS says support.
> + type: boolean
> +
> "#address-cells":
> const: 1
>
> --
> 2.18.0