From: Stanley Chu <stanley.chu@mediatek.com>
To: Ziqi Chen <ziqichen@codeaurora.org>
Cc: nguyenb@codeaurora.org, cang@codeaurora.org,
Alim Akhtar <alim.akhtar@samsung.com>,
vinholikatti@gmail.com, Bean Huo <beanhuo@micron.com>,
Satya Tangirala <satyat@google.com>,
jejb@linux.vnet.ibm.com, Bart Van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org, kwmad.kim@samsung.com,
Andy Gross <agross@kernel.org>,
kernel-team@android.com, salyzyn@google.com,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Avri Altman <avri.altman@wdc.com>,
"moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER
DRIVER..." <linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
rnayak@codeaurora.org, saravanak@google.com,
martin.petersen@oracle.com,
Adrian Hunter <adrian.hunter@intel.com>,
open list <linux-kernel@vger.kernel.org>,
hongwus@codeaurora.org, asutoshd@codeaurora.org
Subject: Re: [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation
Date: Wed, 23 Dec 2020 17:33:18 +0800 [thread overview]
Message-ID: <1608715998.14045.8.camel@mtkswgap22> (raw)
In-Reply-To: <1608644981-46267-1-git-send-email-ziqichen@codeaurora.org>
On Tue, 2020-12-22 at 21:49 +0800, Ziqi Chen wrote:
> As per specs, e.g, JESD220E chapter 7.2, while powering
> off/on the ufs device, RST_N signal and REF_CLK signal
> should be between VSS(Ground) and VCCQ/VCCQ2.
>
> To flexibly control device reset line, refactor the function
> ufschd_vops_device_reset(sturct ufs_hba *hba) to ufshcd_
> vops_device_reset(sturct ufs_hba *hba, bool asserted). The
> new parameter "bool asserted" is used to separate device reset
> line pulling down from pulling up.
>
> Cc: Kiwoong Kim <kwmad.kim@samsung.com>
> Cc: Stanley Chu <stanley.chu@mediatek.com>
> Signed-off-by: Ziqi Chen <ziqichen@codeaurora.org>
Thanks for this fix including ufs-mediatek change as well.
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Tested-by: Stanley Chu <stanley.chu@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-12-23 9:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 13:49 [PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation Ziqi Chen
2020-12-23 9:33 ` Stanley Chu [this message]
2020-12-23 12:17 ` Can Guo
2020-12-23 20:45 ` Avri Altman
2020-12-24 15:35 ` ziqichen
2020-12-28 17:55 ` Bjorn Andersson
2020-12-29 1:18 ` Can Guo
2020-12-29 1:48 ` Can Guo
2021-01-04 18:59 ` Bjorn Andersson
2021-01-04 18:57 ` Bjorn Andersson
2021-01-05 1:39 ` Can Guo
2021-01-04 9:15 ` Adrian Hunter
2021-01-04 18:55 ` Bjorn Andersson
2021-01-05 7:16 ` Adrian Hunter
2021-01-05 7:28 ` Can Guo
2021-01-05 7:33 ` Adrian Hunter
2021-01-05 10:06 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608715998.14045.8.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-team@android.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=satyat@google.com \
--cc=vinholikatti@gmail.com \
--cc=ziqichen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).