From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD57C433E0 for ; Mon, 25 Jan 2021 06:50:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA08A22C9C for ; Mon, 25 Jan 2021 06:50:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA08A22C9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EIQfTrQfCLu8M6xpJQu7yQg1YuePUkmbMb+BiKBodxo=; b=D2K0z8S5EaNub2/9DIfjZgDZH pcIXAi7ZpTegxV1bodky0kNbFfVYiFz+e+KqvQZksX0JJTlTTdpk2sjv3CestaJsZcPC54LL74eLS z9hfjZkJN7gD00wzQGHCYj4IRKGdmQbEsBcRflngoByq/8KDQEUiHkPT4BHV5G+0jtgGJ/PTNg9LH BlqmnyhozauJUFrT1uddXoq9Um8vPHNuQXDV/wWNZc/xbSQ159PNG7uGAVwJBs4cIAkrYwFyKBl8m OePC2Wy8F9cfgM5oNZSDNw1FbAkeuY+8fmHJz4rURdkN7M79y1WhKbe+lVwsy2QqPLdRApecyuoY+ 9x3HpuNRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3vhR-00032N-VT; Mon, 25 Jan 2021 06:50:10 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3vhM-00030a-1M; Mon, 25 Jan 2021 06:50:05 +0000 X-UUID: 655c5d530ae945aaae213676d1542b3e-20210124 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=chRfsW5UPIrsCGcAQg3ddEyEhCQ/dYzTCA0hmQUJvJM=; b=dlpxKz7LFKwncF9T1eZyLj643de1ObkqyxK9z7xWchte4dZLmqUvzdKbMLcmDRlNjKvEWNWXKsHSrsvzVcOjcpPI5RWnC6JM5i2JeqDGNkkc0Hv9MV+QUdruAYZqIrdZ7wA2+0lgbwcFSXTBCKlXAhF9UFgHXBX3AEa3Ty5eW54=; X-UUID: 655c5d530ae945aaae213676d1542b3e-20210124 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1863627650; Sun, 24 Jan 2021 22:49:48 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 24 Jan 2021 22:49:47 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 14:49:42 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 25 Jan 2021 14:49:41 +0800 Message-ID: <1611557381.3184.21.camel@mhfsdcap03> Subject: Re: [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license From: Yong Wu To: Krzysztof Kozlowski Date: Mon, 25 Jan 2021 14:49:41 +0800 In-Reply-To: <20210122213427.mwjyjn2wsgnko7mk@kozik-lap> References: <20210121062429.26504-1-yong.wu@mediatek.com> <20210121062429.26504-3-yong.wu@mediatek.com> <20210122213427.mwjyjn2wsgnko7mk@kozik-lap> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 1FA87B06CC3B3754A9FB2810156820CA7B9663E05E7BC37A175827580DDF19EC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_015004_222367_74494B0C X-CRM114-Status: GOOD ( 23.03 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com, Nicolas Boichat , srv_heupstream@mediatek.com, Robin Murphy , Joerg Roedel , linux-kernel@vger.kernel.org, yi.kuo@mediatek.com, Tomasz Figa , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > currently. Thus we don't have module_exit before. This patch adds > > module_exit and module_license. It is a preparing patch for supporting > > MTK_SMI could been built as a module. > > > > Signed-off-by: Yong Wu > > --- > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > --- a/drivers/memory/mtk-smi.c > > +++ b/drivers/memory/mtk-smi.c > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > } > > module_init(mtk_smi_init); > > + > > +static void __exit mtk_smi_exit(void) > > +{ > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > +} > > +module_exit(mtk_smi_exit); > > + > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > Drivers do not use capital letters, so I have doubts whether this alias > is correct. I didn't care the upper/lower-case. I will change to lower case in next time. MODULE_ALIAS("platform:MediaTek-smi") > > Adding all these should be squashed with changing Kconfig into tristate. > It does not have sense on its own. Thanks very much for review. Only confirm: Squash whole this patch or only squash the MODULE_x into the next patch? > > Best regards, > Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek