Re: [v3,1/3] thermal: mediatek: Relocate driver to mediatek folder

Michael Kao
2021-04-22T08:33:17Z

On Tue, 2021-04-20 at 23:22 +0200, Daniel Lezcano wrote:
> On 12/03/2021 04:40, Michael Kao wrote:
> > Add Mediatek proprietary folder to upstream more thermal zone and
> > cooler
> > drivers. Relocate the original thermal controller driver to it and
> > rename
> > as soc_temp.c to show its purpose more clearly.
>
> We already know the purpose :)
>
> soc_temp gives no additional information.
>
> Either keep the name or give the hardware sensor name. It is a driver
> directory.
>
Dear Daniel,

We introduce the new thermal hardware design called lvts in the new
project. The new project will desgin with lvts will enable the
CONFIG_MTK_SOC_THERMAL_LVTS to build lvts driver[1].
The old project will use CONFIG_MTK_THERMAL to build soc_temp.c.

The new design use lvts device to access thermal sensors in the soc.
The original design access thermal sensors by auxadc.

[1] [v3,2/3] thermal: mediatek: Add LVTS drivers for SoC theraml zones

> > Signed-off-by: Michael Kao <michael.kao@mediatek.com>
> > ---
> > drivers/thermal/Kconfig | 14 ++++-------
> > drivers/thermal/Makefile | 2 +-
> > drivers/thermal/mediatek/Kconfig | 23
> > +++++++++++++++++++
> > drivers/thermal/mediatek/Makefile | 1 +
> > .../{mtk_thermal.c => mediatek/soc_temp.c} | 0
>
> [ ... ]
>
> vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
>
>
> > +config MTK_THERMAL
> > + tristate "Mediatek thermal drivers"
> > + depends on THERMAL_OF
> > + help
> > + This is the option for Mediatek thermal software
> > + solutions. Please enable corresponding options to
> > + get temperature information from thermal sensors or
> > + turn on throttle mechaisms for thermal mitigation.
> > +
> > +if MTK_THERMAL
>
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> All the above not needed.
>
> > +config MTK_SOC_THERMAL
> > + tristate "Temperature sensor driver for mediatek SoCs"
> > + depends on HAS_IOMEM
> > + depends on NVMEM
> > + depends on RESET_CONTROLLER
> > + help
> > + Enable this option if you want to get SoC temperature
> > + information for Mediatek platforms. This driver
> > + configures thermal controllers to collect temperature
> > + via AUXADC interface.
> > +
> > +endif
> > diff --git a/drivers/thermal/mediatek/Makefile
> > b/drivers/thermal/mediatek/Makefile
> > new file mode 100644
> > index 000000000000..f75313ddce5e
> > --- /dev/null
> > +++ b/drivers/thermal/mediatek/Makefile
> > @@ -0,0 +1 @@
> > +obj-$(CONFIG_MTK_SOC_THERMAL) += soc_temp.o
> > diff --git a/drivers/thermal/mtk_thermal.c
> > b/drivers/thermal/mediatek/soc_temp.c
> > similarity index 100%
> > rename from drivers/thermal/mtk_thermal.c
> > rename to drivers/thermal/mediatek/soc_temp.c