From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19516C43470 for ; Wed, 19 May 2021 08:33:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B4FE61363 for ; Wed, 19 May 2021 08:33:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B4FE61363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=16GLf+YPShieSNZLtMEsuz0b+NWZoRwYl04+fHEhwSY=; b=kEKX2ORwDg9ZeRCicR/Jd9VKK RxWLgp3yBFbZOWw6LPXzd3eF7G55Aka75rvlfWD7zP8Dlu7fQMXGXLW9Z2BWTz+2X/FZu6m3Ys7+Z yeG4FwZDPp+jao56kYNPrHJRSsiY4fpMyFOKxXi9ckEUAUKgf66E3lPQTQZ49v88v07GfONVU1ia3 AMMYpS77r/1RFnnArY+k1T/dWVKkgwc3Fj4nBwFcNXryBXYLagN3RLrJp67r6iDOUorQH9VDoQqpI t6QpHnYAT0oMNRXZ86LjW6HrAcDaBaCO54GKzH1pqtKU946cCzhxsCvihq3vHFrhGn9is9oekiGJu RPQHuNAqg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljHdY-003L1e-Jx; Wed, 19 May 2021 08:33:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljHdT-003L0c-VJ for linux-mediatek@desiato.infradead.org; Wed, 19 May 2021 08:33:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=79l6X1uE0HO2OQx85d60C15Qe3uDBb+Qxr5urDNIQgA=; b=em1am+1F33VV+E1J9QgJd9i/Gf 5bms+u8JNMojH7uUzoUhoYalXYceuDZN6vLmi/+zxJ5i8X9y1YmyQ8GhIqf87q1wsz5i6FIyw2dn+ hllIR9pe+7CXjFFIgu0MtPgA8eg7sKtFyhsRzgi1BgZWQ56e/0ee699Ue7gdLIXh6Iy1g+YXSVYfz 4CeFNgIgHYF8gcHi4VvjYNV2SgwZ3TiAvlnKLgxWaxB/91aj40sm0GW6si03YZmRcutQd3dVhQuD5 gJtrVhLqm1l2ChoUiytHZtP5cW5nE8n7mHs+pJhVFuCQ8ovJ+opumXjYU6OdDqULitRTJtVGATqwX kZrn6hbA==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljHdQ-00FHpn-9W for linux-mediatek@lists.infradead.org; Wed, 19 May 2021 08:32:58 +0000 X-UUID: 668b934ee5c544f09a1c774ed9eb0f16-20210519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=79l6X1uE0HO2OQx85d60C15Qe3uDBb+Qxr5urDNIQgA=; b=JtxoNgkPVN1CFa86Zsph317kH/w8sRHjfFDHO5A3fHoDMyALDL7uvPo7+pDuH93jGM72P6oGVWo70fl+kBUeIMaUI/awMUHTZOJMVF5qw0ScBNpZtc+mH8tL0H8SWtvaLgwdywikZLbf443F9FGH9TjD077xTfbtbZnq4OqRc90=; X-UUID: 668b934ee5c544f09a1c774ed9eb0f16-20210519 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1544157358; Wed, 19 May 2021 01:32:54 -0700 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 01:32:34 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 16:32:27 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 16:32:27 +0800 Message-ID: <1621413147.12301.45.camel@mtkswgap22> Subject: Re: [PATCH] mm/sparse: fix check_usemap_section_nr warnings From: Miles Chen To: Mike Rapoport CC: Andrew Morton , , , , , Catalin Marinas , "Will Deacon" , Mark Rutland Date: Wed, 19 May 2021 16:32:27 +0800 In-Reply-To: References: <20210511093114.15123-1-miles.chen@mediatek.com> <1621408729.12301.34.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_013256_365458_6002B466 X-CRM114-Status: GOOD ( 43.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-05-19 at 10:56 +0300, Mike Rapoport wrote: > On Wed, May 19, 2021 at 03:18:49PM +0800, Miles Chen wrote: > > On Wed, 2021-05-19 at 08:30 +0300, Mike Rapoport wrote: > > > (add arm64 people) > > > > > > On Tue, May 11, 2021 at 05:31:14PM +0800, Miles Chen wrote: > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > > > node_data is allocated by kzmalloc. If CONFIG_NEED_MULTIPLE_NODES=n, > > > > > > The node structures are allocated from memblock rather than kzmalloc, so > > > I'd suggest to use "dynamically allocated": > > > > > > ... node_data is dynamically allocated > > > > > > no problem. "dynamically allocated" is better. > > > > > > > > > we use a global variable named "contig_page_data". > > > > > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both kzalloc and > > > > > > ^ coma > > > > > > And here as well, rather then mention kzalloc > > > > > > ok, will fix this in v3 > > > > > > > > ... __pa() can handle both dynamic allocation and symbol cases. > > > > > > > symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, we will have the > > > > "virt_to_phys used for non-linear address" warning when booting. > > > > > > > > To fix it, create a small function to handle both translation. > > > > > > More generally, I wonder how other architectures than support DEBUG_VIRTUAL > > > cope with this? > > > > arm64 support DEBUG_VIRTUAL since v4.11. Before v4.11, a driver can get > > incorrect PA by using __pa() for non-linear addresses and create > > hard-to-debug issues. > > > > arm32...I remember an old issue in ext4: __pa() is used to convert > > non-linear kmap'ed addresses (when CONFIG_HIGHMEM=y). > > > > There are multiple architectures which support CONFIG_DEBUG_VIRTUAL. > > It helps people to catch non-linear addresses at the first place. > > > > find arch -name 'physaddr.c' > > arch/arm/mm/physaddr.c > > arch/arm64/mm/physaddr.c > > arch/mips/mm/physaddr.c > > arch/riscv/mm/physaddr.c > > arch/x86/mm/physaddr.c > > Right, but it seems they check for different things on different > architectures... > > Just to make it clear, I'm Ok with your patch. > All I'm saying is that we probably need to revisit DEBUG_VIRTUAL to make it > consistent across architectures. > Understood, thanks your reviewing. (I think different things are checked because that the "linear address space" is architecture-dependent and may be changed over time. For example, arm64, symbol addresses was in linear address space and moved to "non-linear address space" for address randomization.) Miles > > > > > > Maybe such lack of consistency between debug and no-debug version of > > > arm64::virt_to_phys() is what needs to be fixed at the first place? > > > > > > > Warning message: > > > > [ 0.000000] ------------[ cut here ]------------ > > > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > > > [ 0.000000] Modules linked in: > > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > > > [ 0.000000] sp : ffff800011833e70 > > > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > > > [ 0.000000] Call trace: > > > > [ 0.000000] __virt_to_phys+0x58/0x68 > > > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > > > [ 0.000000] bootmem_init+0x60/0x90 > > > > [ 0.000000] setup_arch+0x184/0x1f0 > > > > [ 0.000000] start_kernel+0x78/0x488 > > > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > > > > > Signed-off-by: Miles Chen > > > > --- > > > > mm/sparse.c | 13 +++++++++++-- > > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > > > index b2ada9dc00cb..55c18aff3e42 100644 > > > > --- a/mm/sparse.c > > > > +++ b/mm/sparse.c > > > > @@ -344,6 +344,15 @@ size_t mem_section_usage_size(void) > > > > return sizeof(struct mem_section_usage) + usemap_size(); > > > > } > > > > > > > > +static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > > > > +{ > > > > +#ifndef CONFIG_NEED_MULTIPLE_NODES > > > > + return __pa_symbol(pgdat); > > > > +#else > > > > + return __pa(pgdat); > > > > +#endif > > > > +} > > > > + > > > > #ifdef CONFIG_MEMORY_HOTREMOVE > > > > static struct mem_section_usage * __init > > > > sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat, > > > > @@ -362,7 +371,7 @@ sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat, > > > > * from the same section as the pgdat where possible to avoid > > > > * this problem. > > > > */ > > > > - goal = __pa(pgdat) & (PAGE_SECTION_MASK << PAGE_SHIFT); > > > > + goal = pgdat_to_phys(pgdat) & (PAGE_SECTION_MASK << PAGE_SHIFT); > > > > limit = goal + (1UL << PA_SECTION_SHIFT); > > > > nid = early_pfn_to_nid(goal >> PAGE_SHIFT); > > > > again: > > > > @@ -390,7 +399,7 @@ static void __init check_usemap_section_nr(int nid, > > > > } > > > > > > > > usemap_snr = pfn_to_section_nr(__pa(usage) >> PAGE_SHIFT); > > > > - pgdat_snr = pfn_to_section_nr(__pa(pgdat) >> PAGE_SHIFT); > > > > + pgdat_snr = pfn_to_section_nr(pgdat_to_phys(pgdat) >> PAGE_SHIFT); > > > > if (usemap_snr == pgdat_snr) > > > > return; > > > > > > > > -- > > > > 2.18.0 > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek