From: Ryder Lee <ryder.lee@mediatek.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Shayne Chen <shayne.chen@mediatek.com>,
"Evelyn Tsai" <evelyn.tsai@mediatek.com>,
Bo Jiao <bo.jiao@mediatek.com>,
Sujuan Chen <sujuan.chen@mediatek.com>,
<linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [RFC PATCH 2/4] mac80211: minstrel_ht: fix minstrel_aggr_check for encap offload
Date: Fri, 28 May 2021 09:54:19 +0800 [thread overview]
Message-ID: <1622166859.31294.2.camel@mtkswgap22> (raw)
In-Reply-To: <47f9c5c2a9c5fd666751e01799a9a167d8776a49.camel@sipsolutions.net>
On Tue, 2021-05-25 at 15:00 +0200, Johannes Berg wrote:
> On Thu, 2021-05-20 at 03:56 +0800, Ryder Lee wrote:
> >
> > + if (!(info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) &&
> > + unlikely(!ieee80211_is_data_qos(hdr->frame_control)))
> > return;
>
> That unlikely() placement seems odd?
>
> johannes
>
I thought about
if (unlikely(!(info->flags & IEEE80211_TX_CTL_HW_80211_ENCAP) &&
!ieee80211_is_data_qos(hdr->frame_control)))
...until I found a similiar case in ieee80211_get_txq, so I kept it in
that way.
Ryder
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-05-28 1:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 19:56 [RFC PATCH 1/4] mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue Ryder Lee
2021-05-19 19:56 ` [RFC PATCH 2/4] mac80211: minstrel_ht: fix minstrel_aggr_check for encap offload Ryder Lee
2021-05-25 13:00 ` Johannes Berg
2021-05-28 1:54 ` Ryder Lee [this message]
2021-05-19 19:56 ` [RFC PATCH 3/4] mac80211: add rate control support " Ryder Lee
2021-05-19 19:56 ` [RFC PATCH 4/4] mt76: mt7615: add 802.11 encap offload support Ryder Lee
2021-05-25 12:59 ` [RFC PATCH 1/4] mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622166859.31294.2.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=bo.jiao@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=shayne.chen@mediatek.com \
--cc=sujuan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox