From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08FFC4338F for ; Sat, 7 Aug 2021 03:51:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96F23610CB for ; Sat, 7 Aug 2021 03:51:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 96F23610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EcHHGugIIvd8YYcbX4bpmvb+B5f6EOL/Y02SO2YtJKo=; b=byEui7nhACuHdY ve2gHAIv/fH1BbVX6ni3ThkrRlTkvr7X77VQch8mV/UJ8OcwWFHecWyL/NlSxrTsvmEiyP2hsRQhV deU6m3T9HbNAxT7Jw9dju13FtP95IGrO5W1J/c5u7sWbZTQxMp2Qt/opG28uJcj2nHDYmDfoNTu9V fJY2YcE9ymR4KKU/k0biRJJediZJKfSi/L5woEzSPFFLDCRd6+/snd2//dNg5RsK14xFutqvX5n2U 2Rpc1zy0EDDQWk4vbpbpv+Bd4cgXTUgY/Kft6IGxGTxVgX1sDONoPJMtalM+YbkIle0AS2HIK5Wbi SmAQt7h3pCpvze1+FXMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCDMu-00E6Ca-CP; Sat, 07 Aug 2021 03:51:28 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCDMr-00E6Bu-Lx; Sat, 07 Aug 2021 03:51:27 +0000 X-UUID: eb27bd0617b3426caaeb5c68c3de5a18-20210806 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=xbNG7nvc2tiwREXnAuN36W+NorCMrtpqAbkcTeVJiiY=; b=fgNeYqq1+CCTZ/LQYe+hOZRUJZX73l5Vlt0v/qJeAsp9utx4F8DFwat89XwRoPbRxSh023q43+lMzkQQFZeVlO/JoVYC5bBBwTjiYYUJOyIgKWuQSsBIC/h5dPqox991VVJa+/GdIZqhjs5izyblt0A7ITUJ9yqVFR+LqoGaTzA=; X-UUID: eb27bd0617b3426caaeb5c68c3de5a18-20210806 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1747716618; Fri, 06 Aug 2021 20:51:22 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 6 Aug 2021 20:51:20 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 7 Aug 2021 11:51:18 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 7 Aug 2021 11:51:18 +0800 Message-ID: <1628308278.23588.3.camel@mtksdaap41> Subject: Re: [PATCH v10 4/5] spmi: mediatek: Add support for MT8195 From: Hsin-hsiung Wang To: Stephen Boyd CC: Matthias Brugger , Rob Herring , , , , , , , Henry Chen Date: Sat, 7 Aug 2021 11:51:18 +0800 In-Reply-To: <162827215909.1975443.852277412377742323@swboyd.mtv.corp.google.com> References: <1627972461-2627-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1627972461-2627-5-git-send-email-hsin-hsiung.wang@mediatek.com> <162827215909.1975443.852277412377742323@swboyd.mtv.corp.google.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_205125_769289_1825E056 X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, sorry for missing other comments, I will confirm it internally and update it. Thanks a lot. On Fri, 2021-08-06 at 10:49 -0700, Stephen Boyd wrote: > Quoting Hsin-Hsiung Wang (2021-08-02 23:34:20) > > From: Henry Chen > > > > Add spmi support for MT8195. > > > > Signed-off-by: Henry Chen > > Missing Signed-off-by from hsin-hsiung.wang here > > > --- > > changes since v9: > > - No change. > > --- > > drivers/spmi/spmi-mtk-pmif.c | 90 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 90 insertions(+) > > > > diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c > > index 94c45d46ab0c..0c320801c9d5 100644 > > --- a/drivers/spmi/spmi-mtk-pmif.c > > +++ b/drivers/spmi/spmi-mtk-pmif.c > > @@ -348,6 +427,14 @@ static const struct pmif_data mt6873_pmif_arb = { > > .soc_chan = 2, > > }; > > > > +static const struct pmif_data mt8195_pmif_arb[] = { > > This is an array of type pmif_data. > > > + { > > + .regs = mt8195_regs, > > + .spmimst_regs = mt8195_spmi_regs, > > + .soc_chan = 2, > > + }, > > +}; > > + > > static int mtk_spmi_probe(struct platform_device *pdev) > > { > > struct pmif *arb; > > @@ -444,6 +531,9 @@ static const struct of_device_id mtk_spmi_match_table[] = { > > { > > .compatible = "mediatek,mt6873-spmi", > > .data = &mt6873_pmif_arb, > > mt6873_pmif_arb is not an array, see the context header above. > > How does this work? Has this been tested? > > > + }, { > > + .compatible = "mediatek,mt8195-spmi", > > + .data = &mt8195_pmif_arb, > > }, { > > /* sentinel */ > > }, > > -- > > 2.18.0 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek