From: zhiyong.tao <zhiyong.tao@mediatek.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: <zhiyong.tao@mediatek.com>, Rob Herring <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
<hui.liu@mediatek.com>, "Eddie Huang" <eddie.huang@mediatek.com>,
Light Hsieh <light.hsieh@mediatek.com>,
Biao Huang <biao.huang@mediatek.com>,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Seiya Wang <seiya.wang@mediatek.com>,
Devicetree List <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v11 3/4] pinctrl: mediatek: mt8195: Add pm_ops
Date: Tue, 31 Aug 2021 17:11:38 +0800 [thread overview]
Message-ID: <1630401098.14536.2.camel@mhfsdcap03> (raw)
In-Reply-To: <CAGXv+5Gx74SxdB_-V3SZB1sQ3=bpUkbkkaHxAyFg9m+7k+HVkw@mail.gmail.com>
On Tue, 2021-08-31 at 15:53 +0800, Chen-Yu Tsai wrote:
> On Mon, Aug 30, 2021 at 8:37 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> >
> > Setting this up will configure wake from suspend properly,
> > and wake only for the interrupts that are setup in wake_mask,
> > not all interrupts.
>
> This sounds like a fix. Please add a Fixes tag for this patch. This makes
> tracking things easier.
>
> So,
>
> Fixes: 6cf5e9ef362a ("pinctrl: add pinctrl driver on mt8195")
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Also this patch is unrelated to the rest. You should send it separately.
> This would also help the maintainer merge it directly.
>
Hi Chen-Yu,
We will add Fixed tag for this patch and send it separately.
Thanks.
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > ---
> > drivers/pinctrl/mediatek/pinctrl-mt8195.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8195.c b/drivers/pinctrl/mediatek/pinctrl-mt8195.c
> > index a7500e18bb1d..892e79703f98 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mt8195.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8195.c
> > @@ -839,6 +839,7 @@ static struct platform_driver mt8195_pinctrl_driver = {
> > .driver = {
> > .name = "mt8195-pinctrl",
> > .of_match_table = mt8195_pinctrl_of_match,
> > + .pm = &mtk_paris_pinctrl_pm_ops,
> > },
> > .probe = mt8195_pinctrl_probe,
> > };
> > --
> > 2.18.0
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-08-31 9:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 0:35 [PATCH v11 0/4] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-08-30 0:36 ` [PATCH v11 1/4] dt-bindings: pinctrl: mt8195: add rsel define Zhiyong Tao
2021-08-31 22:09 ` Rob Herring
2021-09-01 4:35 ` Chen-Yu Tsai
2021-09-02 2:54 ` zhiyong.tao
2021-09-02 3:35 ` Chen-Yu Tsai
2021-09-04 8:40 ` zhiyong.tao
2021-09-06 8:20 ` Chen-Yu Tsai
2021-09-09 6:46 ` zhiyong.tao
2021-09-14 12:27 ` zhiyong.tao
2021-09-15 3:25 ` Chen-Yu Tsai
2021-08-30 0:36 ` [PATCH v11 2/4] dt-bindings: pinctrl: mt8195: change pull up/down description Zhiyong Tao
2021-08-31 22:13 ` Rob Herring
2021-09-01 2:00 ` zhiyong.tao
2021-09-01 10:21 ` Chen-Yu Tsai
2021-09-02 3:31 ` zhiyong.tao
2021-08-30 0:36 ` [PATCH v11 3/4] pinctrl: mediatek: mt8195: Add pm_ops Zhiyong Tao
2021-08-31 7:53 ` Chen-Yu Tsai
2021-08-31 9:11 ` zhiyong.tao [this message]
2021-08-30 0:36 ` [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 Zhiyong Tao
2021-09-01 10:10 ` Chen-Yu Tsai
2021-09-06 3:17 ` zhiyong.tao
2021-09-06 10:09 ` Chen-Yu Tsai
2021-09-09 7:46 ` zhiyong.tao
2021-09-16 9:31 ` zhiyong.tao
2021-09-16 9:40 ` Chen-Yu Tsai
2021-09-17 2:10 ` zhiyong.tao
2021-09-19 19:33 ` Linus Walleij
2021-09-22 1:47 ` zhiyong.tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1630401098.14536.2.camel@mhfsdcap03 \
--to=zhiyong.tao@mediatek.com \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=hongzhou.yang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=light.hsieh@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).