From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 698E0C433EF for ; Sat, 11 Dec 2021 17:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9TtJCgUjSberTaIQ3kXKiNuZ0v6Bn6ClZVX/BiVuBhw=; b=izPc/CRUF9yxeh rY0Wxf/DikVN28bzroY0rHBbTtA0eujTGL6N0tErvnpHOLEp2LDmmT3C3qx9mNddi7JGlVsHYAoZL ivcGiu0aJzuWsSLLjsbJo+7gISCqdwNd/9bf2sOwYo1U5fSiepJb2k2S/w8hexkqZI44wF9NZU4Mq 1oHi6yV3en7RaFzDbGi3D7arW1eC5p0jeSxgez5HDo88kUbQaUXufgLXgkhnbO++3ENytoIAPf86o vKYMh+GDVT0hqdGOLcwmOzpJpwDEs40POgCkTpjds7pRiBe3QWEzkFg4kOAR6BPZKn6IvjzPzdIRD vIZsh+kQ7XlkfVvy4UfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mw5xh-005ICT-PI; Sat, 11 Dec 2021 17:15:05 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mw5xf-005IC4-Eq for linux-mediatek@lists.infradead.org; Sat, 11 Dec 2021 17:15:04 +0000 X-UUID: 92b83715576446728ea4056430a22419-20211211 X-UUID: 92b83715576446728ea4056430a22419-20211211 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 602327352; Sat, 11 Dec 2021 10:15:00 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 11 Dec 2021 09:14:58 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 12 Dec 2021 01:14:44 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 12 Dec 2021 01:14:44 +0800 From: To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/2] mt76: mt7921s: make pm->suspended usage consistent Date: Sun, 12 Dec 2021 01:14:42 +0800 Message-ID: <1639242882-15796-1-git-send-email-sean.wang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211211_091503_553682_7F1FA747 X-CRM114-Status: GOOD ( 12.49 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Sean Wang >> From: Sean Wang >> >> Update pm->suspended usage to be consistent with mt7921e driver. >> >> Signed-off-by: Sean Wang >> --- >> drivers/net/wireless/mediatek/mt76/mt7921/sdio.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/sdio.c b/drivers/net/wireless/mediatek/mt76/mt7921/sdio.c >> index 84be229a899d..44ee9369f6bf 100644 >> --- a/drivers/net/wireless/mediatek/mt76/mt7921/sdio.c >> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/sdio.c >> @@ -278,7 +278,6 @@ static int mt7921s_resume(struct device *__dev) >> struct mt76_dev *mdev = &dev->mt76; >> int err; >> >> - pm->suspended = false; >> clear_bit(MT76_STATE_SUSPEND, &mdev->phy.state); >> >> err = mt7921_mcu_drv_pmctrl(dev); >> @@ -294,7 +293,11 @@ static int mt7921s_resume(struct device *__dev) >> if (!pm->ds_enable) >> mt76_connac_mcu_set_deep_sleep(mdev, false); >> >> - return mt76_connac_mcu_set_hif_suspend(mdev, false); >> + err = mt76_connac_mcu_set_hif_suspend(mdev, false); > >should we check return value here? Something like: > > if (err) > return err; > > pm->suspended = false; > return 0; > >Or, is the chip up even if mt76_connac_mcu_set_hif_suspend() fails? yes, chip is eventually up again by recovered with the following wifi reset with current logic, if do so (not mark pm->suspended back as false to show suspend/resume is over), the pm runtime would not be enabled again after the wifi reset >> + >> + pm->suspended = false; >> + >> + return err; >> } >> >> static const struct dev_pm_ops mt7921s_pm_ops = { >> -- >> 2.25.1 >> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek