Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	bin.zhang@mediatek.com, linux-arm-kernel@lists.infradead.org,
	linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chuanhong Guo <gch981213@gmail.com>,
	benliang.zhao@mediatek.com, Richard Weinberger <richard@nod.at>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property
Date: Mon, 28 Nov 2022 06:20:47 -0600	[thread overview]
Message-ID: <166963790250.472824.6710482280926376664.robh@kernel.org> (raw)
In-Reply-To: <20221128020613.14821-8-xiangsheng.hou@mediatek.com>


On Mon, 28 Nov 2022 10:06:11 +0800, Xiangsheng Hou wrote:
> add rx-sample-delay and rx-latch-latency property.
> 
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> ---
>  .../bindings/spi/mediatek,spi-mtk-snfi.yaml      | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml: properties:rx-sample-delay:minItems: 0 is less than the minimum of 1
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml: properties:rx-sample-delay:maxItems: False schema does not allow 47
	hint: Scalar properties should not have array keywords
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml: properties:rx-sample-delay:minItems: False schema does not allow 0
	hint: Scalar properties should not have array keywords
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221128020613.14821-8-xiangsheng.hou@mediatek.com

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command.



  parent reply	other threads:[~2022-11-28 12:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  2:06 [PATCH 0/9] Add MediaTek MT7986 SPI NAND and ECC support Xiangsheng Hou
2022-11-28  2:06 ` [PATCH 1/9] spi: mtk-snfi: add snfi support for mt7986 IC Xiangsheng Hou
2022-11-28  2:06 ` [PATCH 2/9] spi: mtk-snfi: change default page format to setup default setting Xiangsheng Hou
2022-11-28  2:06 ` [PATCH 3/9] spi: mtk-snfi: add optional nfi_hclk which needed for mt7986 Xiangsheng Hou
2022-11-28  2:06 ` [PATCH 4/9] mtd: nand: ecc-mtk: add ecc support fot mt7986 IC Xiangsheng Hou
2022-11-28  2:06 ` [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings Xiangsheng Hou
2022-11-28  9:00   ` Krzysztof Kozlowski
2022-11-29  2:50     ` Xiangsheng Hou (侯祥胜)
2022-11-29  7:47       ` Krzysztof Kozlowski
2022-11-30  8:18         ` Xiangsheng Hou (侯祥胜)
2022-11-30  8:33           ` Krzysztof Kozlowski
2022-11-28  2:06 ` [PATCH 6/9] spi: mtk-snfi: add snfi sample delay and read latency adjustment Xiangsheng Hou
2022-11-28  2:06 ` [PATCH 7/9] dt-bindings: spi: mtk-snfi: add two timing delay property Xiangsheng Hou
2022-11-28  9:04   ` Krzysztof Kozlowski
2022-11-29  2:50     ` Xiangsheng Hou (侯祥胜)
2022-11-29  7:47       ` Krzysztof Kozlowski
2022-11-30  8:18         ` Xiangsheng Hou (侯祥胜)
2022-11-30  8:35           ` Krzysztof Kozlowski
2022-11-30  9:08             ` Chuanhong Guo
2022-11-28 12:20   ` Rob Herring [this message]
2022-11-28  2:06 ` [PATCH 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller Xiangsheng Hou
2022-11-28  9:13   ` Krzysztof Kozlowski
2022-11-29  2:50     ` Xiangsheng Hou (侯祥胜)
2022-11-28 12:20   ` Rob Herring
2022-12-01  5:24   ` kernel test robot
2022-11-28  2:06 ` [PATCH 9/9] dt-bindings: mtd: ecc-mtk: add mt7986 IC ecc bindings Xiangsheng Hou
2022-11-28  9:14   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166963790250.472824.6710482280926376664.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=benliang.zhao@mediatek.com \
    --cc=bin.zhang@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gch981213@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=xiangsheng.hou@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox