From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>
Cc: Alexandre Bailon <abailon@baylibre.com>,
Balsam CHIHI <bchihi@baylibre.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Alexandre Mergnat <amergnat@baylibre.com>,
kernel@collabora.com, Amit Kucheria <amitk@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 6/6] thermal/drivers/mediatek/lvts_thermal: Manage threshold between sensors
Date: Fri, 7 Jul 2023 10:22:40 +0200 [thread overview]
Message-ID: <16c4d5a9-4eeb-6a92-e97e-6e15eaeb913a@collabora.com> (raw)
In-Reply-To: <20230706153823.201943-7-nfraprado@collabora.com>
Il 06/07/23 17:37, Nícolas F. R. A. Prado ha scritto:
> Each LVTS thermal controller can have up to four sensors, each capable
> of triggering its own interrupt when its measured temperature crosses
> the configured threshold. The threshold for each sensor is handled
> separately by the thermal framework, since each one is registered with
> its own thermal zone and trips. However, the temperature thresholds are
> configured on the controller, and therefore are shared between all
> sensors on that controller.
>
> When the temperature measured by the sensors is different enough to
> cause the thermal framework to configure different thresholds for each
> one, interrupts start triggering on sensors outside the last threshold
> configured.
>
> To address the issue, track the thresholds required by each sensor and
> only actually set the highest one in the hardware, and disable
> interrupts for all sensors outside the current configured range.
>
> Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-07-07 8:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 15:37 [PATCH v3 0/6] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling Nícolas F. R. A. Prado
2023-07-06 15:37 ` [PATCH v3 1/6] thermal/drivers/mediatek/lvts_thermal: Handle IRQ on all controllers Nícolas F. R. A. Prado
2023-07-07 13:46 ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 2/6] thermal/drivers/mediatek/lvts_thermal: Honor sensors in immediate mode Nícolas F. R. A. Prado
2023-07-07 13:50 ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 3/6] thermal/drivers/mediatek/lvts_thermal: Use offset threshold for IRQ Nícolas F. R. A. Prado
2023-07-07 8:21 ` AngeloGioacchino Del Regno
2023-07-07 13:54 ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 4/6] thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts Nícolas F. R. A. Prado
2023-07-07 8:21 ` AngeloGioacchino Del Regno
2023-07-07 13:58 ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 5/6] thermal/drivers/mediatek/lvts_thermal: Don't leave threshold zeroed Nícolas F. R. A. Prado
2023-07-07 8:22 ` AngeloGioacchino Del Regno
2023-07-07 14:05 ` Alexandre Mergnat
2023-07-06 15:37 ` [PATCH v3 6/6] thermal/drivers/mediatek/lvts_thermal: Manage threshold between sensors Nícolas F. R. A. Prado
2023-07-07 8:22 ` AngeloGioacchino Del Regno [this message]
2023-07-07 14:11 ` Alexandre Mergnat
2023-07-13 9:04 ` [PATCH v3 0/6] thermal/drivers/mediatek/lvts_thermal: Fixes to the interrupt handling Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16c4d5a9-4eeb-6a92-e97e-6e15eaeb913a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=abailon@baylibre.com \
--cc=amergnat@baylibre.com \
--cc=amitk@kernel.org \
--cc=bchihi@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox