From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Albert Jakieła" <jakiela@google.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
wenst@chromium.org, rafal@milecki.pl, hsinyi@chromium.org,
nfraprado@collabora.com, macpaul.lin@mediatek.com,
sean.wang@mediatek.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks
Date: Wed, 25 Sep 2024 16:17:52 +0200 [thread overview]
Message-ID: <16ce3558-7733-4c38-b514-c89525faec06@kernel.org> (raw)
In-Reply-To: <20240925080353.2362879-1-jakiela@google.com>
On 25/09/2024 10:03, Albert Jakieła wrote:
> Add entries for MT8186 based Chinchou/Chinchou360 Chromebooks.
> These two are clamshell or convertible with touchscreen, stylus
> and extra buttons.
>
> Signed-off-by: Albert Jakieła <jakiela@google.com>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..110149f5d748 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -239,6 +239,29 @@ properties:
> - enum:
> - mediatek,mt8183-pumpkin
> - const: mediatek,mt8183
> + - description: Google Chinchou360 (Asus Chromebook CZ11 Flip CZ1104F)
> + items:
> + - const: google,chinchou-sku16
> + - const: google,chinchou-sku18
> + - const: google,chinchou-sku19
> + - const: google,chinchou-sku21
> + - const: google,chinchou-sku2147483647
Wasn't sku-maxint removed? I recall same discussion recently... If yes,
then please use same rules for all future Chromebook submissions.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-25 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 8:03 [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks Albert Jakieła
2024-09-25 8:03 ` [PATCH 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
2024-09-26 9:27 ` AngeloGioacchino Del Regno
2024-09-26 23:02 ` Hsin-Yi Wang
2024-09-25 14:17 ` Krzysztof Kozlowski [this message]
2024-09-25 14:36 ` [PATCH 1/2] dt-bindings: arm: mediatek: Add " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16ce3558-7733-4c38-b514-c89525faec06@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=jakiela@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox