From: Rob Herring <robh@kernel.org>
To: Eugen Hristev <eugen.hristev@collabora.com>
Cc: andrew-ct.chen@mediatek.com, tiffany.lin@mediatek.com,
angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name
Date: Fri, 15 Dec 2023 14:03:01 -0600 [thread overview]
Message-ID: <170267057932.303365.14773226712594255838.robh@kernel.org> (raw)
In-Reply-To: <20231215104551.233679-3-eugen.hristev@collabora.com>
On Fri, 15 Dec 2023 12:45:47 +0200, Eugen Hristev wrote:
> Looking at the binding it makes sense that the `-vp8` compatible has
> the `venc_lt_sel` while the other bindings have the `venc_sel` as name for
> the clock.
> This was also mentioned in the txt version of the binding before the
> conversion:
> `
> clock-names: avc encoder must contain "venc_sel", vp8 encoder must
> contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2",
> `
>
> So it is easier to check for compatible that includes vp8, since that's
> just one, to have the requirement for the clock name property as
> `venc_lt_sel`, rather than for all the others, some of which are missing,
> thus for them, the requirement is wrongly `venc_lt_sel`.
>
> Reordered the if/then/else to match `-vp8` and have all the rest of
> the compatibles using the other clock name (`venc_sel`).
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
> Changes in v2:
> - new patch.
> .../bindings/media/mediatek,vcodec-encoder.yaml | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-12-15 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 10:45 [PATCH v2 1/7] media: mediatek: vcodec: fix possible unbalanced PM counter Eugen Hristev
2023-12-15 10:45 ` [PATCH v2 2/7] dt-bindings: media: mtk-vcodec-encoder: add dma-ranges Eugen Hristev
2023-12-15 19:58 ` Rob Herring
2023-12-15 10:45 ` [PATCH v2 3/7] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name Eugen Hristev
2023-12-15 20:03 ` Rob Herring [this message]
2023-12-15 10:45 ` [PATCH v2 4/7] arm64: dts: mediatek: mt8192: fix vencoder " Eugen Hristev
2023-12-15 10:45 ` [PATCH v2 5/7] dt-bindings: media: mtk-vcodec-encoder: add compatible for mt8186 Eugen Hristev
2023-12-15 20:03 ` Rob Herring
2023-12-15 10:45 ` [PATCH v2 6/7] arm64: dts: mediatek: mt8186: fix VENC power domain clocks Eugen Hristev
2023-12-15 10:45 ` [PATCH v2 7/7] arm64: dts: mediatek: mt8186: Add venc node Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170267057932.303365.14773226712594255838.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox