Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: "bo.kong" <bo.kong@mediatek.com>
Cc: angelogioacchino.delregno@collabora.com, conor+dt@kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Bo.Kong@mediatek.com, linux-media@vger.kernel.org,
	 linux-mediatek@lists.infradead.org, krzk+dt@kernel.org,
	mchehab@kernel.org,
	 Project_Global_Chrome_Upstream_Group@mediatek.com,
	matthias.bgg@gmail.com,  linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] media: dt-bindings: add MT8188 AIE
Date: Wed, 25 Dec 2024 04:29:26 -0600	[thread overview]
Message-ID: <173512256651.1988706.15570394656231888489.robh@kernel.org> (raw)
In-Reply-To: <20241225090113.17027-3-bo.kong@mediatek.com>


On Wed, 25 Dec 2024 17:00:21 +0800, bo.kong wrote:
> From: Bo Kong <Bo.Kong@mediatek.com>
> 
> Add YAML device tree bindings for MT8188 AIE.
> 
> Signed-off-by: Bo Kong <Bo.Kong@mediatek.com>
> ---
> 
> Changes in v3:
> none
> 
> Changes in v2:
> 1. Fix coding style
> ---
>  .../bindings/media/mediatek,mt8188-aie.yaml   | 97 +++++++++++++++++++
>  1 file changed, 97 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
 	 $id: http://devicetree.org/schemas/media/mediatek-aie.yaml
 	file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.example.dtb: aie@15310000: reg: [[0, 355532800], [0, 4096]] is too long
	from schema $id: http://devicetree.org/schemas/media/mediatek-aie.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.example.dtb: aie@15310000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/media/mediatek-aie.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241225090113.17027-3-bo.kong@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  reply	other threads:[~2024-12-25 10:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-25  9:00 [PATCH v3 0/4] Add AIE Driver bo.kong
2024-12-25  9:00 ` [PATCH v3 1/4] arm64: dts: mt8188: add aie node bo.kong
2024-12-25  9:00 ` [PATCH v3 2/4] media: dt-bindings: add MT8188 AIE bo.kong
2024-12-25 10:29   ` Rob Herring (Arm) [this message]
2024-12-25 11:28   ` Krzysztof Kozlowski
2024-12-26  3:41   ` CK Hu (胡俊光)
2024-12-25  9:00 ` [PATCH v3 3/4] media: mediatek: add MT8188 AIE driver bo.kong
2024-12-25 11:35   ` Krzysztof Kozlowski
2024-12-26  3:53   ` CK Hu (胡俊光)
2024-12-26  5:20   ` CK Hu (胡俊光)
2024-12-26  5:36   ` CK Hu (胡俊光)
2024-12-26  6:09   ` CK Hu (胡俊光)
2024-12-26  6:50   ` CK Hu (胡俊光)
2024-12-26  7:38   ` CK Hu (胡俊光)
2024-12-27  3:23   ` CK Hu (胡俊光)
2024-12-27  3:54   ` CK Hu (胡俊光)
2024-12-27  5:56   ` CK Hu (胡俊光)
2024-12-27  6:05   ` CK Hu (胡俊光)
2024-12-31  7:45     ` Krzysztof Kozlowski
2024-12-31  7:57       ` CK Hu (胡俊光)
2024-12-31  8:07         ` Krzysztof Kozlowski
2024-12-31  8:13           ` CK Hu (胡俊光)
2024-12-30  7:39   ` CK Hu (胡俊光)
2025-01-07 15:32   ` AngeloGioacchino Del Regno
2024-12-25  9:00 ` [PATCH v3 4/4] uapi: linux: add MT8188 AIE bo.kong
2024-12-26  6:36   ` CK Hu (胡俊光)
2024-12-31  6:55   ` CK Hu (胡俊光)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173512256651.1988706.15570394656231888489.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bo.kong@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox