Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: amergnat@baylibre.com
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	 Maxime Ripard <mripard@kernel.org>,
	Fabien Parent <fparent@baylibre.com>,
	 Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	 Simona Vetter <simona.vetter@ffwll.ch>,
	CK Hu <ck.hu@mediatek.com>,  David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 linux-kernel@vger.kernel.org, Jitao Shi <jitao.shi@mediatek.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v5 1/7] dt-bindings: display: mediatek: dpi: add power-domains property
Date: Wed, 08 Jan 2025 11:22:55 -0600	[thread overview]
Message-ID: <173635697547.725897.5297567835361998238.robh@kernel.org> (raw)
In-Reply-To: <20231023-display-support-v5-1-3905f1e4b835@baylibre.com>


On Wed, 08 Jan 2025 17:15:43 +0100, amergnat@baylibre.com wrote:
> From: Fabien Parent <fparent@baylibre.com>
> 
> DPI is part of the display / multimedia block in MediaTek SoCs, and
> always have a power-domain (at least in the upstream device-trees).
> Add the power-domains property to the binding documentation.
> 
> Fixes: 9273cf7d3942 ("dt-bindings: display: mediatek: convert the dpi bindings to yaml")
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
>  Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: [error] duplication of key "power-domains" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: found duplicate key "power-domains" with value "{}" (original value: "{}")
make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts'
Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: found duplicate key "power-domains" with value "{}" (original value: "{}")
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231023-display-support-v5-1-3905f1e4b835@baylibre.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  reply	other threads:[~2025-01-08 17:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 16:15 [PATCH v5 0/7] Add display support for the MT8365-EVK board amergnat
2025-01-08 16:15 ` [PATCH v5 1/7] dt-bindings: display: mediatek: dpi: add power-domains property amergnat
2025-01-08 17:22   ` Rob Herring (Arm) [this message]
2025-01-09 10:15     ` Alexandre Mergnat
2025-01-08 16:15 ` [PATCH v5 2/7] drm/mediatek: dsi: Improves the DSI lane setup robustness Alexandre Mergnat
2025-01-08 16:15 ` [PATCH v5 3/7] drm/mediatek: add MT8365 SoC support amergnat
2025-01-08 16:15 ` [PATCH v5 4/7] arm64: defconfig: enable display connector support Alexandre Mergnat
2025-01-09  7:53   ` Krzysztof Kozlowski
2025-01-09 10:14     ` Alexandre Mergnat
2025-01-08 16:15 ` [PATCH v5 5/7] arm64: defconfig: enable STARTEK KD070FHFID015 panel Alexandre Mergnat
2025-01-09  7:54   ` Krzysztof Kozlowski
2025-01-09 10:14     ` Alexandre Mergnat
2025-01-08 16:15 ` [PATCH v5 6/7] arm64: dts: mediatek: add display blocks support for the MT8365 SoC Alexandre Mergnat
2025-01-08 16:15 ` [PATCH v5 7/7] arm64: dts: mediatek: add display support for mt8365-evk Alexandre Mergnat
2025-01-09  7:55   ` Krzysztof Kozlowski
2025-01-09 10:15     ` Alexandre Mergnat
2025-01-08 22:34 ` [PATCH v5 0/7] Add display support for the MT8365-EVK board Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173635697547.725897.5297567835361998238.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=catalin.marinas@arm.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fparent@baylibre.com \
    --cc=jitao.shi@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox