Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Guangjie Song <guangjie.song@mediatek.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	 Project_Global_Chrome_Upstream_Group@mediatek.com,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-pm@vger.kernel.org,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 devicetree@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 12/13] dt-bindings: power: mediatek: Add new MT8196 power domain
Date: Thu, 06 Mar 2025 23:42:58 -0600	[thread overview]
Message-ID: <174132617868.2934304.16819918690236058573.robh@kernel.org> (raw)
In-Reply-To: <20250307034454.12243-13-guangjie.song@mediatek.com>


On Fri, 07 Mar 2025 11:44:36 +0800, Guangjie Song wrote:
> Add the binding documentation for power domain on MediaTek MT8196.
> 
> Signed-off-by: Guangjie Song <guangjie.song@mediatek.com>
> ---
>  .../mediatek,mt8196-power-controller.yaml     | 74 +++++++++++++++++++
>  include/dt-bindings/power/mt8196-power.h      | 57 ++++++++++++++
>  2 files changed, 131 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.yaml
>  create mode 100644 include/dt-bindings/power/mt8196-power.h
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.example.dtb: power-controller@1c004000: compatible: ['mediatek,mt8196-scpsys', 'syscon'] is too long
	from schema $id: http://devicetree.org/schemas/power/mediatek,mt8196-power-controller.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/mediatek,mt8196-power-controller.example.dtb: power-controller@1c004000: reg: [[0, 469778432], [0, 4096]] is too long
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250307034454.12243-13-guangjie.song@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  reply	other threads:[~2025-03-07  5:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  3:44 [PATCH 00/13] pmdomain: mediatek: Add MT8196 power domain Guangjie Song
2025-03-07  3:44 ` [PATCH 01/13] pmdomain: mediatek: Support sram isolation Guangjie Song
2025-03-07  3:44 ` [PATCH 02/13] pmdomain: mediatek: Support sram low power Guangjie Song
2025-03-07  3:44 ` [PATCH 03/13] pmdomain: mediatek: Support power on bypass Guangjie Song
2025-03-07  3:44 ` [PATCH 04/13] pmdomain: mediatek: Support check power on/off ack Guangjie Song
2025-03-07  3:44 ` [PATCH 05/13] pmdomain: mediatek: Support voting for power domain Guangjie Song
2025-03-07  3:44 ` [PATCH 06/13] pmdomain: mediatek: Support trigger subsys save/restore regesters Guangjie Song
2025-03-07  3:44 ` [PATCH 07/13] pmdomain: mediatek: Support power domain irq safe Guangjie Song
2025-03-07  3:44 ` [PATCH 08/13] pmdomain: mediatek: Support power domain always on Guangjie Song
2025-03-07  3:44 ` [PATCH 09/13] pmdomain: mediatek: Refactor parameters of init_scp Guangjie Song
2025-03-07  3:44 ` [PATCH 10/13] pmdomain: mediatek: Support bus protect with table Guangjie Song
2025-03-07  3:44 ` [PATCH 11/13] pmdomain: mediatek: Add post init callback Guangjie Song
2025-03-07  3:44 ` [PATCH 12/13] dt-bindings: power: mediatek: Add new MT8196 power domain Guangjie Song
2025-03-07  5:42   ` Rob Herring (Arm) [this message]
2025-03-07  7:41   ` Krzysztof Kozlowski
2025-03-07  3:44 ` [PATCH 13/13] pmdomain: mediatek: Add MT8196 power domain support Guangjie Song
2025-03-10 13:08 ` [PATCH 00/13] pmdomain: mediatek: Add MT8196 power domain AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174132617868.2934304.16819918690236058573.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guangjie.song@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox