Re: [PATCH v1 2/2] mailbox: Add MediaTek TinySYS MHU-like Mailbox

kernel test robot
2025-06-24T12:13:50Z

Hi AngeloGioacchino,

kernel test robot noticed the following build errors:

[auto build test ERROR on jassibrar-mailbox/for-next]
[also build test ERROR on robh/for-next soc/for-next linus/master v6.16-rc3 next-20250623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/dt-bindings-mailbox-Add-MediaTek-TinySYS-MHU-mailbox/20250623-201139
base: https://git.kernel.org/pub/scm/linux/kernel/git/jassibrar/mailbox.git for-next
patch link: https://lore.kernel.org/r/20250623120127.109237-3-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v1 2/2] mailbox: Add MediaTek TinySYS MHU-like Mailbox
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250624/202506241946.HEKwafHB-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250624/202506241946.HEKwafHB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506241946.HEKwafHB-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/mailbox/mtk-tinysys-mailbox.c: In function 'mtk_tinysys_mhu_mbox_startup':
>> drivers/mailbox/mtk-tinysys-mailbox.c:95:9: error: implicit declaration of function 'irq_clear_status_flags' [-Werror=implicit-function-declaration]
95 | irq_clear_status_flags(priv->irq, IRQ_NOAUTOEN);
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/mailbox/mtk-tinysys-mailbox.c:95:43: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'?
95 | irq_clear_status_flags(priv->irq, IRQ_NOAUTOEN);
| ^~~~~~~~~~~~
| IRQF_NO_AUTOEN
drivers/mailbox/mtk-tinysys-mailbox.c:95:43: note: each undeclared identifier is reported only once for each function it appears in
drivers/mailbox/mtk-tinysys-mailbox.c: In function 'mtk_tinysys_mhu_mbox_probe':
>> drivers/mailbox/mtk-tinysys-mailbox.c:152:9: error: implicit declaration of function 'irq_set_status_flags' [-Werror=implicit-function-declaration]
152 | irq_set_status_flags(priv->irq, IRQ_NOAUTOEN);
| ^~~~~~~~~~~~~~~~~~~~
drivers/mailbox/mtk-tinysys-mailbox.c:152:41: error: 'IRQ_NOAUTOEN' undeclared (first use in this function); did you mean 'IRQF_NO_AUTOEN'?
152 | irq_set_status_flags(priv->irq, IRQ_NOAUTOEN);
| ^~~~~~~~~~~~
| IRQF_NO_AUTOEN
cc1: some warnings being treated as errors

vim +/irq_clear_status_flags +95 drivers/mailbox/mtk-tinysys-mailbox.c

90
91 static int mtk_tinysys_mhu_mbox_startup(struct mbox_chan *chan)
92 {
93 struct mtk_tinysys_mhu_mbox *priv = to_mtk_tinysys_mhu_mbox(chan->mbox);
94
> 95 irq_clear_status_flags(priv->irq, IRQ_NOAUTOEN);
96 enable_irq(priv->irq);
97
98 return 0;
99 }
100
101 static void mtk_tinysys_mhu_mbox_shutdown(struct mbox_chan *chan)
102 {
103 struct mtk_tinysys_mhu_mbox *priv = to_mtk_tinysys_mhu_mbox(chan->mbox);
104
105 disable_irq(priv->irq);
106 }
107
108 static const struct mbox_chan_ops tinysys_mbox_chan_ops = {
109 .send_data = mtk_tinysys_mhu_mbox_send_data,
110 .startup = mtk_tinysys_mhu_mbox_startup,
111 .shutdown = mtk_tinysys_mhu_mbox_shutdown,
112 .last_tx_done = mtk_tinysys_mhu_mbox_last_tx_done,
113 };
114
115 static int mtk_tinysys_mhu_mbox_probe(struct platform_device *pdev)
116 {
117 struct device *dev = &pdev->dev;
118 struct mtk_tinysys_mhu_mbox *priv;
119 struct mbox_controller *mbox;
120 int ret;
121
122 /* Allocate memory for device */
123 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
124 if (!priv)
125 return -ENOMEM;
126
127 priv->base = devm_platform_ioremap_resource(pdev, 0);
128 if (IS_ERR(priv->base))
129 return PTR_ERR(priv->base);
130
131 priv->irq = platform_get_irq(pdev, 0);
132 if (priv->irq < 0)
133 return priv->irq;
134
135 priv->pdata = device_get_match_data(dev);
136 if (!priv->pdata)
137 return -EINVAL;
138
139 mbox = &priv->mbox;
140 mbox->dev = dev;
141 mbox->ops = &tinysys_mbox_chan_ops;
142 mbox->txdone_irq = false;
143 mbox->txdone_poll = true;
144 mbox->txpoll_period = 1;
145 mbox->num_chans = 1;
146 mbox->chans = devm_kzalloc(dev, sizeof(*mbox->chans), GFP_KERNEL);
147 if (!mbox->chans)
148 return -ENOMEM;
149
150 platform_set_drvdata(pdev, priv);
151
> 152 irq_set_status_flags(priv->irq, IRQ_NOAUTOEN);
153 ret = devm_request_irq(dev, priv->irq, mtk_tinysys_mhu_mbox_irq,
154 IRQF_TRIGGER_NONE, dev_name(dev), mbox->chans);
155 if (ret < 0)
156 return ret;
157
158 ret = devm_mbox_controller_register(dev, &priv->mbox);
159 if (ret)
160 return dev_err_probe(dev, ret, "Failed to register mailbox\n");
161
162 return 0;
163 }
164

--
0-DAY CI Kernel Test Service