Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
	 angelogioacchino.delregno@collabora.com, amergnat@baylibre.com,
	 Guoqing Jiang <guoqing.jiang@canonical.com>
Cc: zoran.zhan@mediatek.com, linux-sound@vger.kernel.org,
	 linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv
Date: Fri, 18 Jul 2025 13:53:33 +0100	[thread overview]
Message-ID: <175284321358.34755.13837470566210593486.b4-ty@kernel.org> (raw)
In-Reply-To: <20250710011806.134507-1-guoqing.jiang@canonical.com>

On Thu, 10 Jul 2025 09:18:06 +0800, Guoqing Jiang wrote:
> Given mt8365_dai_set_priv allocate priv_size space to copy priv_data which
> means we should pass mt8365_i2s_priv[i] or "struct mtk_afe_i2s_priv"
> instead of afe_priv which has the size of "struct mt8365_afe_private".
> 
> Otherwise the KASAN complains about.
> 
> [   59.389765] BUG: KASAN: global-out-of-bounds in mt8365_dai_set_priv+0xc8/0x168 [snd_soc_mt8365_pcm]
> ...
> [   59.394789] Call trace:
> [   59.395167]  dump_backtrace+0xa0/0x128
> [   59.395733]  show_stack+0x20/0x38
> [   59.396238]  dump_stack_lvl+0xe8/0x148
> [   59.396806]  print_report+0x37c/0x5e0
> [   59.397358]  kasan_report+0xac/0xf8
> [   59.397885]  kasan_check_range+0xe8/0x190
> [   59.398485]  asan_memcpy+0x3c/0x98
> [   59.399022]  mt8365_dai_set_priv+0xc8/0x168 [snd_soc_mt8365_pcm]
> [   59.399928]  mt8365_dai_i2s_register+0x1e8/0x2b0 [snd_soc_mt8365_pcm]
> [   59.400893]  mt8365_afe_pcm_dev_probe+0x4d0/0xdf0 [snd_soc_mt8365_pcm]
> [   59.401873]  platform_probe+0xcc/0x228
> [   59.402442]  really_probe+0x340/0x9e8
> [   59.402992]  driver_probe_device+0x16c/0x3f8
> [   59.403638]  driver_probe_device+0x64/0x1d8
> [   59.404256]  driver_attach+0x1dc/0x4c8
> [   59.404840]  bus_for_each_dev+0x100/0x190
> [   59.405442]  driver_attach+0x44/0x68
> [   59.405980]  bus_add_driver+0x23c/0x500
> [   59.406550]  driver_register+0xf8/0x3d0
> [   59.407122]  platform_driver_register+0x68/0x98
> [   59.407810]  mt8365_afe_pcm_driver_init+0x2c/0xff8 [snd_soc_mt8365_pcm]
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv
      commit: 6bea85979d05470e6416a2bb504a9bcd9178304c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark



      parent reply	other threads:[~2025-07-18 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  1:18 [PATCH V2] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv Guoqing Jiang
2025-07-18  6:48 ` AngeloGioacchino Del Regno
2025-07-18 12:53 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175284321358.34755.13837470566210593486.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=amergnat@baylibre.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=guoqing.jiang@canonical.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zoran.zhan@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox