From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12506CD98E1 for ; Tue, 16 Jun 2026 12:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=JVH7znTjFWA0bwu5sf/vJ2V8033VWhifM4UtG4Dd7PM=; b=WfRchCTbZQaIUmS4UNOMmo/5YW 5EwZu9+S/YWjqr13JMzPepaGlRaeoI8JZQ97hAqXEfp1+kJ6uc/s4Wo+un8zz5Xx1u3/3tuO5Re8f SDn60fgX5Q6/H9MjWCaPjESMdlNr3VP6ANCHBj4s9VQBDYs7g98k42Yw9E8iBZPqUVXVbF2nXphbf gBCTmMd0N4emm/UqRCVJOOeDWF1Oqz/FPgUdnZ+PTMnMloZn0x8tkFZMXRqzMNSSDR/1hWFsSSNcc qxQS4FEYytbXNDc0QxQQIohS+HM1dwEi0+XMa6PWcTiV4RWpCVvNPL89yfMzlT7YHn9gYXGTqWe8k mha7gCXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZSWz-0000000Fjmo-47z7; Tue, 16 Jun 2026 12:04:38 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZSWw-0000000FjlG-0175 for linux-mediatek@lists.infradead.org; Tue, 16 Jun 2026 12:04:35 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-c859a374903so1309159a12.3 for ; Tue, 16 Jun 2026 05:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781611473; x=1782216273; darn=lists.infradead.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=JVH7znTjFWA0bwu5sf/vJ2V8033VWhifM4UtG4Dd7PM=; b=TbX+LvXi4fJbLtkqqXlXGpLtzOJ39y3meCht2sct5M9Wbh9MRwt6x48pC4+V6vqTkx 01ltknDrRupvR3jUBQ5wqPVlwkkBjB67ZcznTD16v++rT2kEsRRwLdfs8rEqELSxexKV yIWRVrk0/wWUuto0HSfWR5rlSAtoT82fS7pZ+LsuKe6/HL9smNC2UOKF2YFlalgFFTOD uDqv83tNLQFvO4ot1IBX+aZvHA3EPGK1Bt7oh1C21tnPNFSaFJ3+rEJhxKKj1RNHpUaS 4AdnvWQ+1y//F04241woIaF/gmphr3vi2/yD7YmCb4F0u2sAHiP52p/ID3N86SClJEI2 raZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781611473; x=1782216273; h=mime-version:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JVH7znTjFWA0bwu5sf/vJ2V8033VWhifM4UtG4Dd7PM=; b=DrtJROxuzvBPPuvTLGhgphDq/9LoCKN4Dl+pRdPiQe7Rin27eTbnXEmyD/teiqPjJc zmszwMe7GUg6KVk89ipnkJJTJ7feTLZWZvlrorkA1yZa3nYufKgEJQ2fUkbgMmXFSwmt Rx45sqfVLy5nFSR664HkyMAIAMgyEJvEI9cpeSx/i3nSJ7f4sG+IHIkb8pTSLNHF4lHT RMJmqxjojimIwgUUaEi2tyOvoRFYP8DwAfsmRdBUlEnFryUvyZmRQNiKyQdS1MfTrw0/ 8qg7xUk0JIqYKHTyk8VOnUygRihINpTJMZhx5tguyQhPZoMgKfkQ5H5eVMcIT/fLss9f wCBQ== X-Forwarded-Encrypted: i=1; AFNElJ9OgXvtTDBgLdTQcmYO6b74xPZ0gyVNUp7Ydmk+QARY7J7imCkRYXDF9JzJ/Kp7un35xOj8H7ZWcnl192b/SA==@lists.infradead.org X-Gm-Message-State: AOJu0YzdyCOk0EHGZe3QLxR8Zt/+QGXfmL6dZshjx+9oPzJfBzJXB9zM /++R1PKwsE08nwHMWcGN3UHFH+CgycV9u1ZSsnp0lafPQ4ZyzC53+CYU X-Gm-Gg: Acq92OFHJxhoSv5Xk3Url2Z8sNz8YzbilNv7vPsofeubb8v9P+sn1fV2sZLLKEZQuMK dGWb1AljpMZsYyKJ8wqV3hDeRDHxJMX5aDLtc3hPQ1ifDyqWoXKXgUPpFrwyav1Jv8S4qpqY/WX cKpunDNuZ2KRPmDCy1rJMYTW4MvmvWlXOLUKal8A0Ce9qXYUtdO7NIotb4i6/AmsH2SflePfs+A cXHAiRDIJbpK+plkd2DVjFmD63cWg4OrjicKZBKKvfrukwV7ImXVb1fVr0Zi+OGr+i4vvkoWE4U jxuHTwneJSGRsj50pPLqWTvr/Ol2pfLgF5fP1bxQsQOGXj1Wq+OzaqUq56ou9u1fPcjAQs24PV1 WbXq6rksemNYAGFy9sRvpGvODOUbsEJcHhmyYr+v8poLCZIMWYD5QKgAZwRjFTuHbpaZq7J7Ta6 Y4iGWSEWFnPKPu38z0V0GtB81Mns8= X-Received: by 2002:a05:6a20:7285:b0:3b4:669c:ee32 with SMTP id adf61e73a8af0-3b7e49d08a6mr3763004637.37.1781611473094; Tue, 16 Jun 2026 05:04:33 -0700 (PDT) Received: from [127.0.1.1] ([47.253.114.73]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c866325d156sm11768400a12.13.2026.06.16.05.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 05:04:32 -0700 (PDT) From: Wayen Yan To: netdev@vger.kernel.org Cc: lorenzo@kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, andrew+netdev@lunn.ch, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2] [net] net: airoha: Stop TX queues on error path in airoha_dev_open Date: Tue, 16 Jun 2026 18:50:39 +0800 Message-ID: <178161146875.2165143.7400860261990016053@gmail.com> Content-Type: text/plain; charset=utf-8 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260616_050434_818981_A97B5E4C X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org In airoha_dev_open(), if airoha_set_vip_for_gdm_port() fails after netif_tx_start_all_queues() has been called, the TX queues remain started while the device configuration is incomplete. This leaves the device in an inconsistent state where packets could be transmitted before the VIP/IFC port configuration is complete. Add netif_tx_stop_all_queues() call on the error path to properly roll back the TX queue state. Fixes: 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC") Signed-off-by: Wayen Yan --- drivers/net/ethernet/airoha/airoha_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c index 31cdb11cd7..cf9c366907 100644 --- a/drivers/net/ethernet/airoha/airoha_eth.c +++ b/drivers/net/ethernet/airoha/airoha_eth.c @@ -1715,8 +1715,10 @@ static int airoha_dev_open(struct net_device *dev) netif_tx_start_all_queues(dev); err = airoha_set_vip_for_gdm_port(port, true); - if (err) + if (err) { + netif_tx_stop_all_queues(dev); return err; + } if (netdev_uses_dsa(dev)) airoha_fe_set(qdma->eth, REG_GDM_INGRESS_CFG(port->id), -- 2.51.0