From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4280606A686 for ; Sat, 21 Nov 2026 20:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=GEdFIjvU; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=W2FuDmHU DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Message-ID:Date :To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=AHUQMxgVMnTXxKbmEWmbNVYVHdBgjW37+wv9A15XjEA=; b=GEdFIjvUVmcNquxoYXyKCfMTze THgjXs1LBttEaL6ujJ34vpAqjhuA24PPD9YC2v+gOmW+WBCrRX/hwRSvxU7pzzPBuRD5MQLefJiBY NW5aw38DWB2R4gyEgeiOX7cq2lqIbd1a+BsBC+RP86RyvreQMeL67ivePAnxJqXMT5hbSpoHGG2q/ b9FwWWnKUq7l5FEQ8DSs+zVBtE69NNJGe0VEeMV9Y9jTGLp0bp8mjPUX/eesdlnkJ8fD86ZTCBoSf +b1jsQQQutYpLuDPQW6N88ii+Rq4fZ9Oo8U1SkSrpUvNq1qMsanuC5AWjtZlQDFw5nE7r/W34jfnb M+AYe91w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUrb0-00000000BHw-2Lae; Sat, 21 Nov 2026 20:22:02 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUraz-00000000BH1-1b38; Sat, 21 Nov 2026 20:22:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3DD7743D95; Sat, 21 Nov 2026 20:22:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BF041F000C0; Sat, 21 Nov 2026 20:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795292520; bh=AHUQMxgVMnTXxKbmEWmbNVYVHdBgjW37+wv9A15XjEA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=W2FuDmHUppm5SPhv9G08NORlp7OkTi/kNvsUtOkx6P0tjFmnH63ZM7hfnlR29q+Gl LxbSs34ywhFlbB3wCS9gqyYsJo03tPku2kV3YTzA3/h8dz/DYi4s4m8eQN9NakQ7kO cuu7d/VVWPqOEiHpMDigzvDGKXKW2OrTT5tekoBjkINl/OHLfEeHm8qGq9lBVxNxY6 q1lldf3d7or+ng9Wzf3Blt/lGriTCIleeLonaZKFL60xZYbr1ZEU8a40rPqAZXceRe kaxCnps21folpZ+nIByCksYl8EFwVwQ1ZPJfcqNGj/7coMbSoNTgNIoHyASCpzsylh h7MUsdCIwj+Nw== Subject: Re: [PATCH net-next v7 1/3] net: ethernet: mtk_eth_soc: fix the RX From: netdev-bot+sashiko@kernel.org To: sandeeph@loljews.com Date: Sat, 21 Nov 2026 20:21:58 +0000 Message-ID: <179529251869.3135.16945484998995426880@kernel.org> In-Reply-To: References: X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Archived-By: MIME-Version: 1.0 X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mason-cw.chang@mediatek.com, linux-kernel@vger.kernel.org, angelogioacchino.delregno@collabora.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, linux@armlinux.org.uk, daniel@makrotopia.org, edumazet@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, kuba@kernel.org, pabeni@redhat.com, lorenzo@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, nbd@nbd.name Sender: "Linux-mediatek" X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] The patch subject "net: ethernet: mtk_eth_soc: fix the RX" does not say what is being fixed and reads like a cut-off sentence. -- net: ethernet: mtk_eth_soc: fix the RX This commit resets dma_addr to DMA_MAPPING_ERROR at the start of every iteration of the mtk_poll_rx() loop. Before this change, a descriptor that took the release_desc path without a new mapping could be re-armed with high address bits left over from the previous descriptor. On MTK_36BIT_DMA SoCs with DRAM above 4 GiB, the hardware would then DMA to the wrong address. > net: ethernet: mtk_eth_soc: fix the RX [Severity: Low] This isn't a bug, but the subject doesn't say what is being fixed. It also reads like a sentence that was cut off. The body describes a specific defect. In mtk_poll_rx(), dma_addr carries over from the previous loop iteration. A descriptor can reach release_desc without a new buffer being mapped: - no netdev for the source port - MTK_RESETTING is set - the refill allocation or mapping fails In those cases rxd2 gets the previous descriptor's high address bits, while rxd1 still holds the current descriptor's low bits. None of this shows up in the shortlog, and stable and patchwork tooling rely on the shortlog. Could the subject be made more descriptive, for example: net: ethernet: mtk_eth_soc: reset RX dma_addr for every descriptor -- Sashiko AI review ยท https://netdev-ai.bots.linux.dev/sashiko/#/patchset/patch-7d2c457e68de6b53b7348d1bdbeadcec%40loljews.com