From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: "trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org"
<flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Mutharaju,
Prasanna (P.)" <mkarthi3-Vi+0cqmPEYlBDgjK7y7TUQ@public.gmane.org>,
"treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org"
<treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] soc: Fix for clean up pmic driver - trivial
Date: Mon, 05 Oct 2015 14:21:33 +0200 [thread overview]
Message-ID: <19210837.P9sIqrRUPt@wuerfel> (raw)
In-Reply-To: <20151005114444.GA11494@jci-VirtualBox>
On Monday 05 October 2015 11:45:08 Mutharaju, Prasanna wrote:
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index f432291..628a919 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -35,8 +35,8 @@
> #define PWRAP_GET_WACS_RDATA(x) (((x) >> 0) & 0x0000ffff)
> #define PWRAP_GET_WACS_FSM(x) (((x) >> 16) & 0x00000007)
> #define PWRAP_GET_WACS_REQ(x) (((x) >> 19) & 0x00000001)
> -#define PWRAP_STATE_SYNC_IDLE0 (1 << 20)
> -#define PWRAP_STATE_INIT_DONE0 (1 << 21)
> +#define PWRAP_STATE_SYNC_IDLE0 BIT(20)
> +#define PWRAP_STATE_INIT_DONE0 BIT(21)
>
> /* macro for WACS FSM */
> #define PWRAP_WACS_FSM_IDLE 0x00
> @@ -52,7 +52,7 @@
> #define PWRAP_DEW_WRITE_TEST_VAL 0xa55a
>
> /* macro for manual command */
> -#define PWRAP_MAN_CMD_SPI_WRITE (1 << 13)
> +#define PWRAP_MAN_CMD_SPI_WRITE BIT(13)
> #define PWRAP_MAN_CMD_OP_CSH (0x0 << 8)
> #define PWRAP_MAN_CMD_OP_CSL (0x1 << 8)
> #define PWRAP_MAN_CMD_OP_CK (0x2 << 8)
I'd say the original version is clearer because of the context that
does not use (and should not) use BIT().
Arnd
prev parent reply other threads:[~2015-10-05 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 11:45 [PATCH] soc: Fix for clean up pmic driver - trivial Mutharaju, Prasanna (P.)
2015-10-05 12:21 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19210837.P9sIqrRUPt@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mkarthi3-Vi+0cqmPEYlBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox