From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C756C4332F for ; Thu, 14 Dec 2023 17:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QtivBajJ2uEBe/N9gJN8n3kJKYyoOgnif0RBAayWfuQ=; b=hWV2kCmWyaqCLCYigzG3CsAO4F COAASQMiPaGBlz2b2yhQWRc5LW1PihowyBSyWR0lr/7LlcrOci7FnFCYw8y0oNDLsXJPq2NvKIRDs wpS2Fx9/rnRyTD1MeaGkkrOP0HBnvoGV+QHR+ufqwDrJSOmZxOOop0bhEvRk8pUZpweQ1zYKJcgze tBmEy5DwB3fkcRVho87hmGXUk7S9vyJOq7hlgxvs97r/z40oOm4aNveMHHtcJzD+QVFcTOSeR5Qtb WWIOJWXfTfek3JaIqLu06TrKBNgpiv7nArZ4FEevtJkuoOHv0wJ44Bo9BOuYT+4WWuz96L7bslt9a YnwUa9dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDpuv-000ybs-06; Thu, 14 Dec 2023 17:54:37 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDpus-000yb7-0W; Thu, 14 Dec 2023 17:54:35 +0000 X-UUID: d0ca3d669aa911ee9b09ad09c76753c8-20231214 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=QtivBajJ2uEBe/N9gJN8n3kJKYyoOgnif0RBAayWfuQ=; b=ql44oSG2Bhr9l3tkGQz4JLjMujdHaHk2gtPBefJsL/VTiueEMMjVViLtSgyRnVhqwW1hmY/VtdvArqL73TIfpghrnEHb8EOHmW0hDFM2jKF/5CfP5LCBKk1JDaS+wf721FWyHMHbCM0OZZFVoGwrDqkVgwKOXwGRdCKpyzCDbVw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:4767db56-73fd-4051-95c2-15a8947d12f8,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:302f2fbd-2ac7-4da2-9f94-677a477649d9,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: d0ca3d669aa911ee9b09ad09c76753c8-20231214 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1587421876; Thu, 14 Dec 2023 10:54:23 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 15 Dec 2023 01:54:21 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 15 Dec 2023 01:54:20 +0800 Message-ID: <1ce43346-3f60-b614-cdcc-7d9db8dec758@mediatek.com> Date: Fri, 15 Dec 2023 01:54:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] arm64: mediatek: remove broken pmic interrupt property Content-Language: en-US To: AngeloGioacchino Del Regno , Arnd Bergmann , , Matthias Brugger , Ben Lok CC: Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , , , , References: <20231212214737.230115-1-arnd@kernel.org> From: Macpaul Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_095434_202450_1975E672 X-CRM114-Status: GOOD ( 23.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 12/13/23 19:09, AngeloGioacchino Del Regno wrote: > Il 12/12/23 22:47, Arnd Bergmann ha scritto: >> From: Arnd Bergmann >> >> The pmic is connected to the GIC, which uses four-cell interrupt >> properties, >> but its interrupt is specified as two-cell that would only make sense >> for >> the GPIO irqchip: >> >> arch/arm64/boot/dts/mediatek/mt8195.dtsi:464.4-27: Warning >> (interrupts_property): /soc/i2c@11d01000/pmic@34:#interrupt-cells: >> size is (8), expected multiple of 16 >> >> Remove the interrupt for now to shut up the warning. When someone >> figures out >> what the correct interrupt and parent are, we can add it back. >> > > Please, can anyone from MediaTek comment on that? Sorry for late response, I've just stuck in other tasks and didn't notice this patch is for genio-1200-evk. I've tested 6.7-rc1 but I thought it might be an issue in origin mt8195.dtsi and not be related to board dts. > I see a mt6360_pins on PIO: >             pinmux = , >                  ; > > ...and that's GPIO128, which may effectively be the IRQ pin for MT6360. > > Still, I'm not sure whether the interrupt is on GIC or PIO, please > clarify, > otherwise we will have to get this commit upstream. > I think it could be solved by adding 'interrupt-parent = <&pio>;' to mt6360 node. But currently I have no much time to verify it. I'll try to find some time to find out the solution tomorrow. > Thanks, > Angelo > >> Fixes: f2b543a191b6 ("arm64: dts: mediatek: add device-tree for Genio >> 1200 EVK board") >> Signed-off-by: Arnd Bergmann >> --- >>   arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts | 2 -- >>   1 file changed, 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >> b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >> index 70b465f7c6a7..a409ef998746 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >> @@ -238,8 +238,6 @@ &i2c6 { >>       mt6360: pmic@34 { >>           compatible = "mediatek,mt6360"; >>           reg = <0x34>; >> -        interrupts = <128 IRQ_TYPE_EDGE_FALLING>; >> -        interrupt-names = "IRQB"; >>           interrupt-controller; >>           #interrupt-cells = <1>; >>           pinctrl-0 = <&mt6360_pins>; > Thanks for pointing out the issue! Let's see if it could be solved by adding 'interrupt-parents'. Macpaul Lin