From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zichen Xie <zichenxie0106@gmail.com>
Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com,
shayne.chen@mediatek.com, sean.wang@mediatek.com,
kvalo@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, johannes.berg@intel.com,
quic_adisi@quicinc.com, deren.wu@mediatek.com,
chui-hao.chiu@mediatek.com, mingyen.hsieh@mediatek.com,
howard-yh.hsu@mediatek.com, StanleyYP.Wang@mediatek.com,
allen.ye@mediatek.com, benjamin-jw.lin@mediatek.com,
Bo.Jiao@mediatek.com, evelyn.tsai@mediatek.com,
meichia.chiu@mediatek.com, linux-wireless@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, chenyuan0y@gmail.com,
zzjas98@gmail.com
Subject: Re: [PATCH v6] wifi: mt76: Fix NULL Dereference caused by mt76_connac_get_he_phy_cap()
Date: Tue, 8 Oct 2024 17:54:52 +0200 [thread overview]
Message-ID: <1cf6d772-e7e0-4e40-bcac-d687706f1055@kernel.org> (raw)
In-Reply-To: <CANdh5G4r_WVt3ao0sFqFA7F3BUHi9wNwWENVHjPXyRGq2sotZA@mail.gmail.com>
On 08/10/2024 16:34, Zichen Xie wrote:
> Hi,
>
> But Matthias suggested checking for NULL immediately after the declaration.
Why do you keep top-posting? Matthias also asked you to stop, so that
part you ignore? Responding to such HTML, top-post emails is a pain, so
that is the last time I am writing here. I will be NAK-ing other totally
bogus and untested patches, though.
> Re: [PATCH v5] wifi: mt76: Fix NULL Dereference caused by
> mt76_connac_get_he_phy_cap() - Matthias Brugger (kernel.org)
> <https://lore.kernel.org/all/7daf8976-91ee-4045-a9a7-d9d14d53c6dd@gmail.com/>
Don't send HTML. Anyway I do not see anything indicating that this
should be before declarations. I see clearly: "before any use of struct
vc." which is not before declarations.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-10-08 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 23:35 [PATCH v6] wifi: mt76: Fix NULL Dereference caused by mt76_connac_get_he_phy_cap() Gax-c
2024-10-08 6:19 ` Krzysztof Kozlowski
[not found] ` <CANdh5G4r_WVt3ao0sFqFA7F3BUHi9wNwWENVHjPXyRGq2sotZA@mail.gmail.com>
2024-10-08 15:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cf6d772-e7e0-4e40-bcac-d687706f1055@kernel.org \
--to=krzk@kernel.org \
--cc=Bo.Jiao@mediatek.com \
--cc=StanleyYP.Wang@mediatek.com \
--cc=allen.ye@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin-jw.lin@mediatek.com \
--cc=chenyuan0y@gmail.com \
--cc=chui-hao.chiu@mediatek.com \
--cc=deren.wu@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=howard-yh.hsu@mediatek.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=meichia.chiu@mediatek.com \
--cc=mingyen.hsieh@mediatek.com \
--cc=nbd@nbd.name \
--cc=quic_adisi@quicinc.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=zichenxie0106@gmail.com \
--cc=zzjas98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).