From: Alexandre Mergnat <amergnat@baylibre.com>
To: Trevor Wu <trevor.wu@mediatek.com>,
broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.com,
perex@perex.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com
Cc: alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/7] ASoC: mediatek: mt8188: separate ADDA playback dai from capture dai
Date: Tue, 23 May 2023 16:22:29 +0200 [thread overview]
Message-ID: <1d3ba1d6-ff91-eedf-90e1-4ef5b16354c2@baylibre.com> (raw)
In-Reply-To: <20230523021933.3422-2-trevor.wu@mediatek.com>
On 23/05/2023 04:19, Trevor Wu wrote:
> MT8188 will support SOF. In SOF, be_hw_params_fixup callback are used to
Can you write what is SOF please ? (Sound Open Firmware I guess ?)
> configure BE hardware parameters. However, playback and capture stream
> share the same callback function in which it can't know the stream type.
>
> It's possible to require different paremters for playback and capture
paremters => parameters
Code looks good, after the commit messages fixes:
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-05-23 14:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 2:19 [PATCH v2 0/7] ASoC: mt8188: add new board support Trevor Wu
2023-05-23 2:19 ` [PATCH v2 1/7] ASoC: mediatek: mt8188: separate ADDA playback dai from capture dai Trevor Wu
2023-05-23 14:22 ` Alexandre Mergnat [this message]
2023-05-24 2:09 ` Trevor Wu (吳文良)
2023-05-23 2:19 ` [PATCH v2 2/7] ASoC: dt-bindings: mediatek,mt8188-mt6359: remove ADDA_BE from link-name Trevor Wu
2023-05-23 16:26 ` Alexandre Mergnat
2023-05-24 2:25 ` Trevor Wu (吳文良)
2023-05-24 13:28 ` Alexandre Mergnat
2023-05-24 13:45 ` Trevor Wu (吳文良)
2023-05-24 14:46 ` Alexandre Mergnat
2023-05-25 3:20 ` Trevor Wu (吳文良)
2023-05-23 2:19 ` [PATCH v2 3/7] ASoC: mediatek: mt8188-mt6359: register hdmi/dp jack pins Trevor Wu
2023-05-24 13:35 ` Alexandre Mergnat
2023-05-23 2:19 ` [PATCH v2 4/7] ASoC: mediatek: common: soundcard driver add dai_fmt support Trevor Wu
2023-05-24 14:12 ` Alexandre Mergnat
2023-05-25 3:07 ` Trevor Wu (吳文良)
2023-05-23 2:19 ` [PATCH v2 5/7] ASoC: soc-dapm.c: clean up debugfs for freed widget Trevor Wu
2023-05-24 14:51 ` Alexandre Mergnat
2023-05-23 2:19 ` [PATCH v2 6/7] ASoC: mediatek: mt8188-mt6359: support new board with nau88255 Trevor Wu
2023-05-24 15:51 ` Alexandre Mergnat
2023-05-25 3:44 ` Trevor Wu (吳文良)
2023-05-25 7:47 ` Alexandre Mergnat
2023-05-23 2:19 ` [PATCH v2 7/7] ASoC: dt-bindings: mediatek,mt8188-mt6359: add NAU8825 support Trevor Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d3ba1d6-ff91-eedf-90e1-4ef5b16354c2@baylibre.com \
--to=amergnat@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox