From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B954ACD1284 for ; Thu, 4 Apr 2024 11:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:Cc:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GJytlEt+WhhRZBi21Zv1Wz8Vy3pYwZk1F9iNOT6+jus=; b=iGKEiBAC4V4h4AjaTRWVgdwLf0 bf+9W2KIQT1b1PTX6Vhigr++qrZqC8ZQ2Kban193HBIoWNH+q063oYMokqbPaFXpPAedPfYC5k4bl iwD2c557o8EQ6NVXeKbds/p4ABbmAX+EVEBnYvskD5tNLvEJRusPPBO0OuA4yaqsrTHsQDrQyorUZ QzSti67QOPh0aEWxG9PD83jNHWLCVGDE3sw/QgU06d0Rtk1JUTF7jElVZfwbaWf08Dywr+934uDlg SZHOOuFQ2PP7YR27f+t1WoL3yKWOPv8+pQTpI+huM260ZUCZ8nFE84E7HLXZGkkq7/cN4ADRpqp0Y aPkBHCVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsLbq-00000002Rbq-3oOp; Thu, 04 Apr 2024 11:50:22 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsLbJ-00000002R5o-1jVg; Thu, 04 Apr 2024 11:50:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712231372; bh=yVE6soaiuubo6FwqB1b2RlNAfh1E2hAC+6bdTlmFD4M=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=k5Cz74tf/dgUW5zQbrAB9mloDLLTkX/YloFmSi3LzjRaGVDtLkU09bVD1zoiEe6S7 iaYDqdtTdLz/8X/f6tzHGmoeAvS4StZKStAO4hUMmma3H9RtjLpF+478YGwrVRyWnz 6vCNusGyDzyMFN4hd4Ri+S+++zKwfD/eELz6ufegR5lr7ggJVT4DAXNbBUcxrbXZ1a ybk+45n7nyg/siyvKSEworlOpRY2BPgTDHoNbnF0EX27MD6YdsguOYCViU5zFYlSdT mt0lUp+ZVy6TkBsDSD0pF2KGn16AHlpn2XbBs4MPehq/4seuowKHR3DilJ6rjGGb3s EQqY5UWoy6BVA== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 90AFE378200D; Thu, 4 Apr 2024 11:49:27 +0000 (UTC) Message-ID: <1dd3cead-6251-425f-b050-582892da0800@collabora.com> Date: Thu, 4 Apr 2024 16:49:59 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] wifi: mt76: connac: check for null before dereferencing To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger , AngeloGioacchino Del Regno References: <20240301144406.2808307-1-usama.anjum@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_044950_712405_ED7DF33A X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Soft reminder On 3/11/24 10:11 PM, Muhammad Usama Anjum wrote: > Soft reminder > > On 3/1/24 7:44 PM, Muhammad Usama Anjum wrote: >> The wcid can be NULL. It should be checked for validity before >> dereferencing it to avoid crash. >> >> Fixes: 098428c400ff ("wifi: mt76: connac: set correct muar_idx for mt799x chipsets") >> Signed-off-by: Muhammad Usama Anjum >> --- >> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c >> index af0c2b2aacb00..7af60eebe517a 100644 >> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c >> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c >> @@ -283,7 +283,7 @@ __mt76_connac_mcu_alloc_sta_req(struct mt76_dev *dev, struct mt76_vif *mvif, >> }; >> struct sk_buff *skb; >> >> - if (is_mt799x(dev) && !wcid->sta) >> + if (is_mt799x(dev) && wcid && !wcid->sta) >> hdr.muar_idx = 0xe; >> >> mt76_connac_mcu_get_wlan_idx(dev, wcid, &hdr.wlan_idx_lo, > -- BR, Muhammad Usama Anjum