Re: [PATCH v4 19/19] drm/mediatek: Add support for MT8196 multiple mmsys

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

On Thu, 2025-08-28 at 16:07 +0800, Paul Chen wrote:
> From: Nancy Lin <nancy.lin@mediatek.com>
> 
> Add code to support MT8196 SOC Multi MMSYS Driver
> 
> Signed-off-by: Nancy Lin <nancy.lin@mediatek.com>
> Signed-off-by: Paul-pl Chen <paul-pl.chen@mediatek.com>
> ---

[snip]

>  static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
>  	.main_path = mt2701_mtk_ddp_main,
>  	.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
> @@ -326,8 +374,65 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
>  	.min_height = 1,
>  };
>  
> -static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = {

You should not remove mt8365_mmsys_driver_data.

Regards,
CK

> -	.mmsys_dev_num = 1,
> +static const struct mtk_mmsys_driver_data mt8196_dispsys0_driver_data = {
> +	.main_path = mt8196_mtk_ddp_disp0_main,
> +	.main_len = ARRAY_SIZE(mt8196_mtk_ddp_disp0_main),
> +	.main_order = 1,
> +	.ext_path = mt8196_mtk_ddp_disp0_ext,
> +	.ext_len = ARRAY_SIZE(mt8196_mtk_ddp_disp0_ext),
> +	.ext_order = 1,
> +	.third_path = mt8196_mtk_ddp_disp0_third,
> +	.third_len = ARRAY_SIZE(mt8196_mtk_ddp_disp0_third),
> +	.third_order = 1,
> +	.mmsys_id = DISPSYS0,
> +	.mmsys_dev_num = 4,
> +	.max_width = 8191,
> +	.min_width = 2, /* 2-pixel align when ethdr is bypassed */
> +	.min_height = 1,
> +};
> +