From: Jason Gunthorpe <jgg@nvidia.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Christian Benvenuti <benve@cisco.com>,
Heiko Stuebner <heiko@sntech.de>,
iommu@lists.linux.dev, Jernej Skrabec <jernej.skrabec@gmail.com>,
Joerg Roedel <joro@8bytes.org>, Leon Romanovsky <leon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev,
Matthias Brugger <matthias.bgg@gmail.com>,
Nelson Escobar <neescoba@cisco.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Robin Murphy <robin.murphy@arm.com>,
Samuel Holland <samuel@sholland.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Chen-Yu Tsai <wens@csie.org>, Will Deacon <will@kernel.org>,
Yong Wu <yong.wu@mediatek.com>
Cc: patches@lists.linux.dev
Subject: [PATCH 2/3] iommu/amd: Don't call report_iommu_fault()
Date: Wed, 22 Oct 2025 14:12:51 -0300 [thread overview]
Message-ID: <2-v1-391058a85f30+14b-iommu_set_fault_jgg@nvidia.com> (raw)
In-Reply-To: <0-v1-391058a85f30+14b-iommu_set_fault_jgg@nvidia.com>
This old style API is only used by drivers/gpu/drm/msm and
drivers/remoteproc, neither are used on x86 HW. Remove the dead code to
discourage new users.
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/amd/iommu.c | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 2e1865daa1cee8..072c80bb2c2b3a 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -840,29 +840,6 @@ static void amd_iommu_report_page_fault(struct amd_iommu *iommu,
dev_data = dev_iommu_priv_get(&pdev->dev);
if (dev_data) {
- /*
- * If this is a DMA fault (for which the I(nterrupt)
- * bit will be unset), allow report_iommu_fault() to
- * prevent logging it.
- */
- if (IS_IOMMU_MEM_TRANSACTION(flags)) {
- /* Device not attached to domain properly */
- if (dev_data->domain == NULL) {
- pr_err_ratelimited("Event logged [Device not attached to domain properly]\n");
- pr_err_ratelimited(" device=%04x:%02x:%02x.%x domain=0x%04x\n",
- iommu->pci_seg->id, PCI_BUS_NUM(devid), PCI_SLOT(devid),
- PCI_FUNC(devid), domain_id);
- goto out;
- }
-
- if (!report_iommu_fault(&dev_data->domain->domain,
- &pdev->dev, address,
- IS_WRITE_REQUEST(flags) ?
- IOMMU_FAULT_WRITE :
- IOMMU_FAULT_READ))
- goto out;
- }
-
if (__ratelimit(&dev_data->rs)) {
pci_err(pdev, "Event logged [IO_PAGE_FAULT domain=0x%04x address=0x%llx flags=0x%04x]\n",
domain_id, address, flags);
@@ -873,7 +850,6 @@ static void amd_iommu_report_page_fault(struct amd_iommu *iommu,
domain_id, address, flags);
}
-out:
if (pdev)
pci_dev_put(pdev);
}
--
2.43.0
next prev parent reply other threads:[~2025-10-22 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 17:12 [PATCH 0/3] Cleanup around iommu_set_fault_handler() Jason Gunthorpe
2025-10-22 17:12 ` [PATCH 1/3] RDMA/usnic: Remove iommu_set_fault_handler() Jason Gunthorpe
2025-10-23 5:02 ` Baolu Lu
2025-10-22 17:12 ` Jason Gunthorpe [this message]
2025-10-23 12:34 ` [PATCH 2/3] iommu/amd: Don't call report_iommu_fault() Robin Murphy
2025-10-23 14:26 ` Jason Gunthorpe
2025-11-20 19:26 ` Jason Gunthorpe
2025-10-22 17:12 ` [PATCH 3/3] iommu: Allow drivers to say if they use report_iommu_fault() Jason Gunthorpe
2025-10-23 5:06 ` Baolu Lu
2025-10-23 11:24 ` Robin Murphy
2025-10-23 14:54 ` Jason Gunthorpe
2025-10-23 16:58 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2-v1-391058a85f30+14b-iommu_set_fault_jgg@nvidia.com \
--to=jgg@nvidia.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benve@cisco.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=joro@8bytes.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=neescoba@cisco.com \
--cc=patches@lists.linux.dev \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).