From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH 3/4] mmc: mediatek: Add tune support Date: Thu, 15 Oct 2015 10:58:32 +0200 Message-ID: <20151015085832.GV7858@pengutronix.de> References: <1444729078-26585-1-git-send-email-chaotian.jing@mediatek.com> <1444729078-26585-4-git-send-email-chaotian.jing@mediatek.com> <20151015062958.GG7825@pengutronix.de> <1444898402.8751.21.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1444898402.8751.21.camel@mhfsdcap03> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Chaotian Jing Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On Thu, Oct 15, 2015 at 04:40:02PM +0800, Chaotian Jing wrote: > On Thu, 2015-10-15 at 08:29 +0200, Sascha Hauer wrote: > > Hi, > > > > On Tue, Oct 13, 2015 at 05:37:57PM +0800, Chaotian Jing wrote: > > > @@ -1260,6 +1547,16 @@ static int msdc_drv_probe(struct platform_device *pdev) > > > goto host_free; > > > } > > > > > > + host->src_clk_parent = clk_get_parent(host->src_clk); > > > + host->hs400_src = devm_clk_get(&pdev->dev, "400mhz"); > > > + if (IS_ERR(host->hs400_src)) { > > > + dev_dbg(&pdev->dev, "Cannot find 400mhz at dts!\n"); > > > + } else if (clk_set_parent(host->src_clk_parent, host->hs400_src) < 0) { > > > + dev_err(host->dev, "Failed to set 400mhz source clock!\n"); > > > + ret = -EINVAL; > > > + goto host_free; > > > + } > > > > This is a static setup. We have device tree bindings for doing this. > > Please look for assigned-clocks and assigned-clock-parents. Doing stuff > > like this in the driver almost certainly leads to problems because the > > next SoC will have different requirements here. > > > > Sorry, I cannot understand it, could you help to give some sample code > about this ? assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL> assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2> Have a look at drivers/clk/clk-conf.c and Documentation/devicetree/bindings/clock/clock-bindings.txt Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |